add ":target" to selector for removing "collapsed" class [#535966]

when the uri fragment identifier links to an element in a collapsed fieldset, i wish the "collapsed" class were removed from that fieldset, so the browser can move the view port to that element and the element is visible

currently the "collapsed" class is removed from fieldsets which contain elements matching the selector, 'input.error, textarea.error, select.error', so that errors are visible. this patch adds ":target" to that selector, so the "collapsed" class is also removed from fieldsets which contain the target of the uri fragment identifier.

in other words, given the markup,

[...]

[...]

- when accessed with the uri, http://...#foo, the "collapsed" class will be removed from the fieldset, so the browser can move the view port to the div and the div is visible

Comment	File	Size	Author
#11	collapse-anchor.patch	779 bytes	casey
#11
#3	collapsetarget.patch	796 bytes	casey
#3
#1	535966.patch	718 bytes	jablko
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jablko CreditAttribution: jablko commented 30 July 2009 at 20:45

File	Size
535966.patch	718 bytes

oops, guess that markup shoulda been,

[...]
<fieldset class="collapsible collapsed">
[...]
<div id="foo">
[...]
</fieldset>
[...]

Comment #2

11 September 2009 at 10:30

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #3

casey CreditAttribution: casey commented 20 March 2010 at 15:24

File	Size
collapsetarget.patch	796 bytes

I agree on the idea.

The uri fragment identifier however can easily change. So this patch isn't complete. We could use the hashchange event. For cross-browser compatibility we would need jquery.ba-bbq.js. Needs some discussion.

Comment #4

casey CreditAttribution: casey commented 13 May 2010 at 17:19

Status:

Needs work

» Needs review

Lets forget hashchange for a moment and focus on the easy part first.

Patch still applies.

Comment #5

casey CreditAttribution: casey commented 13 May 2010 at 17:20

Issue tags:

+Usability

tagging

Comment #6

Dries CreditAttribution: Dries commented 13 May 2010 at 17:44

I'm confused by the comments above. Are you recommending we commit this 'as is' or are you saying we need to do more work on it?

Comment #7

casey CreditAttribution: casey commented 13 May 2010 at 17:49

Oh, I am sorry. Yes I mean commit this 'as is'. It is functional as long as the hash doesn't change.

The part that doesn't work is when you click an anchor-link that is inside an collapsed fieldset, the fieldset won't automaticly open.

Comment #8

Dries CreditAttribution: Dries commented 14 May 2010 at 07:25

Status:

Needs review

» Fixed

Committed to CVS HEAD. Thanks.

Comment #9

Kiphaas7 CreditAttribution: Kiphaas7 commented 14 May 2010 at 10:34

Status:

Fixed

» Needs work

Got this error in firebug console:
uncaught exception: Syntax error, unrecognized expression: Syntax error, unrecognized expression: target

After debugging, it turns out the following line is responsible:

      if ($('.error, :target', $fieldset).length) {

Which is exactly what this patch changed...
Since the :target selector is not listed in the api (http://api.jquery.com/category/selectors/), I don't think it is actually supported by jquery?

Maybe some code of the link below can be used instead..
http://stackoverflow.com/questions/1451292/what-does-selector-ahref-mean...