Relative links updater needs improvements

I tested the patch against nodes, node revisions and comments and it works great. One very minor tweak was to pass the text by reference as suggested in a previous post.

There is a regression. I re-synced http://scratch.drupal.org/ and the support and contribute pages are no longer converted.

Are you saying that we can't upgrade a single drupal.org post?! (The default input format has the codefilter enabled so it is available to all users.) Furthermore, the contribute and support page are not using the codefilter. Not upgrading people's data, is corrupting it too.

Either your explanation is wrong, or the update script is wrong. Posts that are formatted using the default input format are being upgraded despite the fact they use the codefilter. On drupal.org, posts with format 1 are upgraded. Please elaborate. Thanks!

Added some (handy) information:

mysql> select * from filters order by format;
+------------+--------+--------+-------+
| module     | weight | format | delta |
+------------+--------+--------+-------+
| urlfilter  |      0 |      1 |     0 |
| filter     |      2 |      1 |     2 |
| legacy     |     10 |      1 |     0 |
| filter     |      1 |      1 |     0 |
| codefilter |     10 |      1 |     0 |
| filter     |      0 |      2 |     1 |
| filter     |      0 |      3 |     2 |
| legacy     |     10 |      3 |     0 |
| codefilter |     10 |      3 |     0 |
+------------+--------+--------+-------+

Got it now.

I take issue with the whole point behind update 178. I have relative URLs I don't want to be hard linked to the base_path(). That's why I like filters in Drupal; they don't modify the DB content, just the output. So I ask, why isn't this update done as part of a filter mod instead of gambling with the data source?

deekayen: good point, we should not tamper with user's data.

The reason this wasn't offered as a filter is mostly because of the perfomance impact of rewriting URLs dynamically. We opted for speed over portability, with the intention of making a contrib module to handle the portability aspect. For more details see

http://lists.drupal.org/archives/development/2006-03/msg00193.html