Pointed by moshe:
For better DX in hook_field_info_alter() et al, we should ensure that we provide at least empty arrays for 'settings' before calling drupal_alter().

CommentFileSizeAuthor
#4 field_settings_default.patch3.38 KByched
#1 field_settings_default.patch3.38 KByched
field_settings_default.patch1.76 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_settings_default.patch3.38 KB

Also realized the sample code for the _alter() hooks is buggy.

Status: Needs review » Needs work

The last submitted patch failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review

Requiring retest. The patch is really harmless, I don't see why it would break 'Enable / disable modules' tests.
Esp. if the original patch passed green. The second patch just adds changes to field.api.php

Interestingly, I get test those test failures when running this test locally on a vanilla HEAD... But the bot seems to return *some* green tests still...

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_settings_default.patch3.38 KB

No retest ? Reposting, then.

yched’s picture

yched CreditAttribution: yched commented

That's better.

Those test failures on HEAD look strange, though... I have 6 fails in 'Enable / disable modules' tests, locally 100% reproducible on a vanilla HEAD, and the bot (or at least some slaves) has them intermittently, it seems...

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

Thanks yched. Very minor tidying up here.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. The MySQL database failed when I committed this so it might not be properly recorded. :/

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.