Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is similar to #519612: File Validators missing drupal_function_exists(), where I'm putting an entire CCK field (or just a D7 "Field") into a separate include file, file.field.inc. However, the #value_callback isn't getting called because that file is never included when submitting a form (oddly it does get included when building the form though). This just changes the function_exists() to drupal_function_exists() to ensure it gets pulled in and the field is assigned a value.
| Comment | File | Size | Author |
|---|---|---|---|
| form_value_callback_exists.patch | 1.17 KB | quicksketch | |
Comments
Comment #2
drewish CreditAttribution: drewish commentedSuper simple fix. Should we do a mass find and replace for function_exists() in core?
Comment #3
drewish CreditAttribution: drewish commentedi guess the testbot and i cross posted... i'm going to request a retest because i'm not seeing how this would affect the image url generation.
Comment #4
catch@drewish, no we shouldn't do a mass find and replace - see #528896: Small optimization to module_invoke_all() and related issues, I'd be fine with function_exists() || drupal_function_exists() as a find and replace though.
Comment #5
Dries CreditAttribution: Dries commentedAlright, let's make form API slower! Committed to CVS HEAD. ;-)
Thanks.
Comment #6
quicksketchYeah sorry about that :-(
drupal_function_exists() and the registry is something we should be all-or-nothing about. I'd be interested in the possibility catch suggested: function_exists() || drupal_function_exists(). Let's pick it up over there in #528896: Small optimization to module_invoke_all().