Rename initialization functions for clarity [#517542]

Comment	File	Size	Author
#9	517542-fix.patch	649 bytes	Damien Tournoud

#4	rename-bootstrap-functions.patch	14.78 KB	David Strauss

#2	rename-bootstrap-functions.patch	14.83 KB	David Strauss

	rename-bootstrap-functions.patch	1.99 KB	David Strauss

Comment #1

Crell CreditAttribution: Crell commented 13 July 2009 at 07:03

+1 on concept. The second two I agree with entirely.

I'm not sure that drupal_initialize_php is the best name for the first function. It's setting defaults and configuration for both the $_SERVER super-global environment object and various php_ini() settings. So, maybe _php is the right suffix there? What about drupal_initialize_environment()? I'm not sure here either way, just bringing it up.

There's also drupal_session_initialize(). Should the name patterns match?

We should probably also fix init_theme() for the same reasons mentioned above. drupal_initialize_theme() / drupal_theme_initialize() ?

Log in or register to post comments

Comment #2

David Strauss

he/him

CreditAttribution: David Strauss commented 13 July 2009 at 07:23

Title:

Rename bootstrap functions for clarity

» Rename initialization functions for clarity

File	Size
rename-bootstrap-functions.patch	14.83 KB

Here's a much-expanded patch.

Log in or register to post comments

Comment #3

Dries CreditAttribution: Dries commented 13 July 2009 at 07:25

Title:	Rename initialization functions for clarity	» Rename bootstrap functions for clarity
Status:	Needs review	» Reviewed & tested by the community

Much better, IMO. Can try to commit it later today.

Log in or register to post comments

Comment #4

David Strauss

he/him

CreditAttribution: David Strauss commented 13 July 2009 at 07:29

Title:	Rename bootstrap functions for clarity	» Rename initialization functions for clarity
Status:	Reviewed & tested by the community	» Needs review

File	Size
rename-bootstrap-functions.patch	14.78 KB

Here's an update without silly renaming of the block module theme function.

Log in or register to post comments

Comment #5

Crell CreditAttribution: Crell commented 13 July 2009 at 07:42

Status:

Needs review

» Reviewed & tested by the community

Yay, clarity!

Log in or register to post comments

Comment #6

Damien Tournoud CreditAttribution: Damien Tournoud commented 13 July 2009 at 08:54

Nice!

Log in or register to post comments

Comment #7

Dries CreditAttribution: Dries commented 14 July 2009 at 10:22

Status:

Reviewed & tested by the community

» Fixed

Committed to CVS HEAD. Thanks.

Log in or register to post comments

Comment #8

Damien Tournoud CreditAttribution: Damien Tournoud commented 14 July 2009 at 11:22

Category:	task	» bug
Priority:	Normal	» Critical
Status:	Fixed	» Active

This broke everything badly, because a variable_init() call was not converted in DrupalWebTestCase:

rename-bootstrap-functions.patch	passed	Passed: 153 passes, 0 fails, 0 exceptions Detailed results

^ Only 153 passes is a sign.

Log in or register to post comments

Comment #9

Damien Tournoud CreditAttribution: Damien Tournoud commented 14 July 2009 at 11:24

Status:

Active

» Needs review

File	Size
517542-fix.patch	649 bytes

Log in or register to post comments

Comment #10

David Strauss

he/him

CreditAttribution: David Strauss commented 14 July 2009 at 11:29

Does the test bot not catch fatal errors from calling undefined functions?

Log in or register to post comments

Comment #11

David Strauss

he/him

CreditAttribution: David Strauss commented 14 July 2009 at 11:30

Status:

Needs review

» Reviewed & tested by the community

DamZ's change should definitely go in. Not sure how I missed that one.

Log in or register to post comments

Comment #12

Damien Tournoud CreditAttribution: Damien Tournoud commented 14 July 2009 at 11:32

See #443154: Fatal errors in tests not reported as failures for the parent issue. I consider this a bug in PIFR, but there are some disagreement there.