break at beginning doesn't work [#51522]

Comment	File	Size	Author
#9	node.module_36.patch	1.06 KB	m3avrck

#5	node.module_35.patch	1.08 KB	m3avrck

#1	node_46.patch	571 bytes	paddy_deburca

Comment #1

paddy_deburca CreditAttribution: paddy_deburca commented 3 March 2006 at 20:22

File	Size
node_46.patch	571 bytes

The problem stems from the fact that strpos restuns a boolean false if nothing is found - of course this boolean false has the same numeric value as the first position in a string i.e. zero

This patch compares the result of strpos as a boolean and allows a delimiter to be in position zero.

Paddy.

Log in or register to post comments

Comment #2

paddy_deburca CreditAttribution: paddy_deburca commented 4 March 2006 at 08:35

Status:

Active

» Needs review

Just to signal that a patch exists and needs review.

Paddy.

Log in or register to post comments

Comment #3

liquidcms CreditAttribution: liquidcms commented 4 March 2006 at 09:00

great.. thanks i'll try it out.

Log in or register to post comments

Comment #4

Dries CreditAttribution: Dries commented 7 March 2006 at 19:38

Status:

Needs review

» Fixed

Works for me. Code looks good. Committed.

Log in or register to post comments

Comment #5

m3avrck CreditAttribution: m3avrck commented 9 March 2006 at 19:22

Status:

Fixed

» Reviewed & tested by the community

File	Size
node.module_35.patch	1.08 KB

This patch forgot to take into account that if strpos() doesn't find anything, it returns FALSE. This is the default case, with auto teaser generation and when you compare $delimiter >= 0, in this case, $delimiter === FALSE and you don't get your auto generated teaser.

To fix this, we should check to make sure $delimiter is actually an number, indicating a string postion, and if so, use strpos(). Otherwise, if it isn't a number, then no  was found.