Here's an interesting little oddity. In Drupal 6, the options for "Poll duration" were: 1/2/4 days; 1/2/4/8/16 weeks; 1 year.
In Drupal 7, the options make less sense IMHO, as: 1/2/4 days; 1/2/4 weeks; 1 month and 3 weeks (!); 3 months and 3 weeks (?!?); and 1 year.
I'd like to change Drupal 7's options to the following: 1/2/3/4/5/6 days; 1/2/3/4 weeks; 1/2/3/6/9 months; 1 year.
I'm assuming that this is a trivially easy fix to make, code-wise, which is perfect for me: I'm actually not a coder, and would like this experience to learn how to contribute code to Drupal.
(Of course I could be wrong about how easy this fix is: For example, I can't find the text string "week" in the poll module at all! Odd.)
Comment | File | Size | Author |
---|---|---|---|
#10 | drupal.poll-duration.patch | 1.06 KB | sun |
#8 | poll_module_duration_fix-20090912.patch | 701 bytes | tgeller |
#6 | poll_module_duration_fix.patch | 701 bytes | tgeller |
#3 | poll_duration_fix.patch | 675 bytes | tgeller |
#1 | poll_duration_fix.patch | 688 bytes | tgeller |
Comments
Comment #1
tgeller CreditAttribution: tgeller commented...and here's my first patch! Be gentle with me.
Naw, I'm just kidding. Tear it apart. ;) Seriously, I'd like to know whether I did this right, or (if not) what could be done better.
Comment #3
tgeller CreditAttribution: tgeller commentedSecond try... I messed up on file names (I think).
Comment #5
tgeller CreditAttribution: tgeller commentedO.K., I give up... can anyone help me figure out what I'm doing wrong?
Comment #6
tgeller CreditAttribution: tgeller commentedFigured it out, thanks to help from John Morahan in http://drupal.org/node/519216 . Anyhoo, here we go again....
Comment #8
tgeller CreditAttribution: tgeller commentedO.K., I don't know why that failed -- maybe because the test happened about 45 days after the patch was rolled? But anyway, here we go again with a newly rolled patch...
Comment #9
lambic CreditAttribution: lambic commentedpatch works
Comment #10
sunWe can write this a little bit cleaner and provide some clues about the values we assign. :)
Comment #11
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks!