hook_comment for update operation not invoked from admin/comment [#51142]

This is necessary to allow modules to react on publish/unpublish changes to comments.

Please, review attached patch.

Comment	File	Size	Author
#5	comment.module.admin_approval_hooks_0.patch	742 bytes	markus_petrux
#5
#4	comment.module.admin_approval_hooks.patch	740 bytes	markus_petrux
#4
#1	comment.module.admin_update_hook_0.patch	690 bytes	markus_petrux
#1
	comment.module.admin_update_hook.patch	422 bytes	markus_petrux

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

markus_petrux CreditAttribution: markus_petrux commented 24 February 2006 at 14:32

File	Size
comment.module.admin_update_hook_0.patch	690 bytes

For consistency, I have modified the patch to also write a notice to watchdog.

Please, review.

Comment #2

moshe weitzman CreditAttribution: moshe weitzman commented 26 February 2006 at 03:40

if possible, use a diff syntax which shows the function that is being patches. i have this line in my .cvsrc

diff -F^f -u

Comment #3

markus_petrux CreditAttribution: markus_petrux commented 26 February 2006 at 11:42

Sorry, moshe. I generate patches with WinMerge and there is not such an option. I have manually added the function name. I hope that is ok.

Also, I have changed the patch so it now, instead of invoking hook_comment('update'), it invokes hook_comment('publish') or hook_comment('unpublish'). I believe that is much wiser.

File	Size
comment.module.admin_approval_hooks.patch	740 bytes

Comment #5

markus_petrux CreditAttribution: markus_petrux commented 5 March 2006 at 16:15

File	Size
comment.module.admin_approval_hooks_0.patch	742 bytes

re-rolled. Please, consider this for 4.7. Thanks

Comment #6

moshe weitzman CreditAttribution: moshe weitzman commented 5 March 2006 at 20:35

Status:

Needs review

» Reviewed & tested by the community

verified.

in a separate patch, perhaps someone can also remove those excessive drupal_goto() calls in the validate and submit part of this admin form. you are supposed to return a path from submit now. in validate, you may simply omit the drupal_goto() entirely.