If javascript is disabled the toolbar overlaps a part of the header in Garland (on FF3, but probably on others too).

Attached is a screen shot and a patch to fix the problem.

CommentFileSizeAuthor
behaving-toolbar-without-js.patch584 bytestic2000
toolbar-without-js.jpg45.65 KBtic2000
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keith.smith’s picture

keith.smith CreditAttribution: keith.smith commented
Title: Admin toolbar brakes style on Garland when js is disabled. » Admin toolbar breaks style on Garland when js is disabled.
xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
CreditAttribution: xmacinfo commented
Issue tags: +Quick fix
alpritt’s picture

alpritt CreditAttribution: alpritt commented
Status: Needs review » Reviewed & tested by the community

Tested in IE6, IE7, IE8 and Chrome on Windows, and the latest versions of Safari, Firefox and Opera on the Mac, all with JavaScript disabled and enabled.

And the code change makes sense too.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

I saw a similar overlap with javascript enabled which went away when the page finished loading a few times, looks like a good change.

tic2000’s picture

tic2000 CreditAttribution: tic2000 commented

@catch
Yes, because that class is added by toolbar.js when the DOM is ready. The more time it takes to load, more time you have to notice the problem.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.