Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
While working at #504564: Make summary length behave with fields I've noticed this small error so I opened this small issue to not kill kittens there.
text_field_sanitize takes $items by reference, but in its last part assigns values to $item instead of $items.
Comment | File | Size | Author |
---|---|---|---|
text-field-sanitize.patch | 807 bytes | tic2000 | |
Comments
Comment #1
tic2000 CreditAttribution: tic2000 commentedadding tag
Comment #2
catchLooks good. The other patch is introducing new tests for some of this stuff (not sure if exactly this code though), but let's get it in so that can proceed. Looks like text_field_load() which is a direct copy and paste has this right, so either I fixed the code when copying and pasting, or broke it in hook_field_sanitize() when reworking that...
Comment #3
tic2000 CreditAttribution: tic2000 commentedIf "the other patch" means the one I mention in the OP then the last patch has no new test. The one that had a test already got committed, now I only went a step further because the first patch treated the effect, but not the cause.
Comment #4
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.