While working at #504564: Make summary length behave with fields I've noticed this small error so I opened this small issue to not kill kittens there.

text_field_sanitize takes $items by reference, but in its last part assigns values to $item instead of $items.

CommentFileSizeAuthor
text-field-sanitize.patch807 bytestic2000
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tic2000’s picture

Issue tags: +Quick fix

adding tag

catch’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. The other patch is introducing new tests for some of this stuff (not sure if exactly this code though), but let's get it in so that can proceed. Looks like text_field_load() which is a direct copy and paste has this right, so either I fixed the code when copying and pasting, or broke it in hook_field_sanitize() when reworking that...

tic2000’s picture

If "the other patch" means the one I mention in the OP then the last patch has no new test. The one that had a test already got committed, now I only went a step further because the first patch treated the effect, but not the cause.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.