Haven't found the time to take a look into the code, but this are the complains from POTX and the first two strings are bugs for sure... the others may be false alarms only. Watchdog shouldn't use t() any longer in D6+.

The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',t('Chunk size has been updated to %d.',$chunk_size)) in xmlsitemap.pages.inc on line 49.

The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',t('The maximum number of allowed links has been reached.'),WATCHDOG_ERROR) in xmlsitemap.pages.inc on line 52.

Processing xmlsitemap.module...


Processing xmlsitemap.install...


The first parameter to $t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings
there.
At $t($msg) in xmlsitemap.install on line 569.

The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',$msg,array(),WATCHDOG_ERROR) in xmlsitemap.install on line 547.

The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',$msg,array(),WATCHDOG_ERROR) in xmlsitemap.install on line 565.
CommentFileSizeAuthor
#3 507620.patch6.63 KBDave Reid
#1 507620.patch6.65 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Status: Active » Needs review
FileSize
6.65 KB

Patch attached for review that fixes issues with watchdog().

hass’s picture

Status: Needs review » Needs work

Do not add double blanks to strings, please. For e.g. for this module. You must

The rest looks good...

Dave Reid’s picture

FileSize
6.63 KB

Good find, even though I didn't add that. :) Revised patch for review.

hass’s picture

Status: Needs work » Needs review
Anonymous’s picture

Status: Needs review » Fixed

Applied and committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.