Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Haven't found the time to take a look into the code, but this are the complains from POTX and the first two strings are bugs for sure... the others may be false alarms only. Watchdog shouldn't use t() any longer in D6+.
The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',t('Chunk size has been updated to %d.',$chunk_size)) in xmlsitemap.pages.inc on line 49.
The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',t('The maximum number of allowed links has been reached.'),WATCHDOG_ERROR) in xmlsitemap.pages.inc on line 52.
Processing xmlsitemap.module...
Processing xmlsitemap.install...
The first parameter to $t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings
there.
At $t($msg) in xmlsitemap.install on line 569.
The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',$msg,array(),WATCHDOG_ERROR) in xmlsitemap.install on line 547.
The first two watchdog() parameters should be literal strings. There should be no variables, concatenation, constants or even a t() call the
re.
At watchdog('xmlsitemap',$msg,array(),WATCHDOG_ERROR) in xmlsitemap.install on line 565.
Comment | File | Size | Author |
---|---|---|---|
#3 | 507620.patch | 6.63 KB | Dave Reid |
#1 | 507620.patch | 6.65 KB | Dave Reid |
Comments
Comment #1
Dave ReidPatch attached for review that fixes issues with watchdog().
Comment #2
hass CreditAttribution: hass commentedDo not add double blanks to strings, please. For e.g.
for this module. You must
The rest looks good...
Comment #3
Dave ReidGood find, even though I didn't add that. :) Revised patch for review.
Comment #4
hass CreditAttribution: hass commentedComment #5
Anonymous (not verified) CreditAttribution: Anonymous commentedApplied and committed.