Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are several threads around stating that MyISAM is not a good choice for high-traffic sites and InnoDB is better. I was wondering why we hard-code the value at MyISAM and not let MySQL just choose based on its configured settings and no one in #drupal was able to tell me, so here is a patch which does this.
Comment | File | Size | Author |
---|---|---|---|
#9 | no-myisam.patch | 2.2 KB | webchick |
#6 | database.mysql_13.patch | 10.76 KB | webchick |
database.mysql_12.patch | 10.54 KB | webchick | |
Comments
Comment #1
drewish CreditAttribution: drewish commented+1 on this patch and making the change part of the coding standards.
Comment #2
killes@www.drop.org CreditAttribution: killes@www.drop.org commented+1
Comment #3
webchickOk then... Setting this RTBC.
Also, an excerpt from http://dev.mysql.com/doc/refman/5.0/en/storage-engines.html to support this change:
"If you omit the ENGINE or TYPE option, the default storage engine is used. Normally, this is MyISAM, but you can change it by using the --default-storage-engine or --default-table-type server startup option, or by setting the storage_engine or table_type system variable."
Comment #4
pfaocle+1
Seems sensible to me. Perhaps we need a mention of this in INSTALL.mysql.txt too?
Comment #5
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedWanted to apply it, but doesn't apply anymore.
Comment #6
webchickOops! Let's try this. :)
Comment #7
webchickComment #8
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedapplied
Comment #9
webchickCrap. Forgot about updates.inc too. Sorry. ;(
Comment #10
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedapplied, had to edit a bit.
Comment #11
markus_petrux CreditAttribution: markus_petrux commentedIt doesn't worth to open a new issue, if I'm mistaken...
Looking at the changes made by this patch I figured that in updates.inc there are newly created tables that are defined with the UTF8 stuff (example: system_update_173), but some others don't (example: see system_update_166). Is that correct?
Comment #12
markus_petrux CreditAttribution: markus_petrux commentedNevermind, system_update_169 does the job for previously created tables. sorry. :-?
Comment #13
(not verified) CreditAttribution: commented