There are several threads around stating that MyISAM is not a good choice for high-traffic sites and InnoDB is better. I was wondering why we hard-code the value at MyISAM and not let MySQL just choose based on its configured settings and no one in #drupal was able to tell me, so here is a patch which does this.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drewish’s picture

+1 on this patch and making the change part of the coding standards.

killes@www.drop.org’s picture

+1

webchick’s picture

Status: Needs review » Reviewed & tested by the community

Ok then... Setting this RTBC.

Also, an excerpt from http://dev.mysql.com/doc/refman/5.0/en/storage-engines.html to support this change:

"If you omit the ENGINE or TYPE option, the default storage engine is used. Normally, this is MyISAM, but you can change it by using the --default-storage-engine or --default-table-type server startup option, or by setting the storage_engine or table_type system variable."

pfaocle’s picture

+1

Seems sensible to me. Perhaps we need a mention of this in INSTALL.mysql.txt too?

killes@www.drop.org’s picture

Status: Reviewed & tested by the community » Needs work

Wanted to apply it, but doesn't apply anymore.

webchick’s picture

FileSize
10.76 KB

Oops! Let's try this. :)

webchick’s picture

Status: Needs work » Reviewed & tested by the community
killes@www.drop.org’s picture

Status: Reviewed & tested by the community » Fixed

applied

webchick’s picture

Status: Fixed » Reviewed & tested by the community
FileSize
2.2 KB

Crap. Forgot about updates.inc too. Sorry. ;(

killes@www.drop.org’s picture

Status: Reviewed & tested by the community » Fixed

applied, had to edit a bit.

markus_petrux’s picture

It doesn't worth to open a new issue, if I'm mistaken...

Looking at the changes made by this patch I figured that in updates.inc there are newly created tables that are defined with the UTF8 stuff (example: system_update_173), but some others don't (example: see system_update_166). Is that correct?

markus_petrux’s picture

Nevermind, system_update_169 does the job for previously created tables. sorry. :-?

Anonymous’s picture

Status: Fixed » Closed (fixed)