All of our source files should have an $Id$ line at the top. This ended up getting lost between Drupal 6 and Drupal 7. Your task is to add it back in! :)

New patch contributors only, please.

CommentFileSizeAuthor
#9 jquery.add_id_3.patch424 bytesafreeman
#6 jquery.add_id_2.patch397 bytesafreeman
#3 jquery.add_id.patch393 bytesafreeman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

afreeman’s picture

afreeman CreditAttribution: afreeman commented

I'll take this.

afreeman’s picture

afreeman CreditAttribution: afreeman commented
Assigned: Unassigned » afreeman
afreeman’s picture

afreeman CreditAttribution: afreeman commented
FileSize
jquery.add_id.patch393 bytes
afreeman’s picture

afreeman CreditAttribution: afreeman commented
Status: Active » Needs review
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Needs work

That is going to cause bad, bad things when it's expanded out. :) Let's wrap it in a comment.

afreeman’s picture

afreeman CreditAttribution: afreeman commented
Status: Needs work » Needs review
FileSize
jquery.add_id_2.patch397 bytes

Let's try that again.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Since this is your first patch and all, I have to give you the full "webchick treatment." ;)

[23:15]  <webchick> afreeman, Two things:
[23:15]  <webchick> 1. There should be a space between // and $
[23:15]  <webchick> 2. There should be a newline after it.
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Needs work
afreeman’s picture

afreeman CreditAttribution: afreeman commented
Status: Needs work » Needs review
FileSize
jquery.add_id_3.patch424 bytes

How many n00bs does it take to add a $Id$ tag?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly.

Coding standards are met.

All tests pass.

I opened a HTTP request with curl and passed the output through a regexp filter with grep to verify that the CVS comment token was actually there.

But there's a serious problem with this patch. That problem is that it hasn't been marked RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD! :D Great job, afreeman! :)

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.