Remove stupid assertion [#504016]

Comment	File	Size	Author
#2	panels.patch	2.39 KB	catch

	panels.patch	2.06 KB	catch

Comment #1

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 27 June 2009 at 16:55

Status:

Needs review

» Needs work

To clarify for those not in #drupal. ;)

We enabled search module by default in #503982: Enable search module by default and it caused this test to fail. The reason is because the test makes some hard-coded assumptions about what sections should and should not appear here.

However, if we're going to remove this assertion, we should also remove the $extras variable, since there's no reason to calculate it if we never check it.

But looking at this closer, I'm not sure this is exactly the right fix. That whole test could do with some general sanity checking.

Log in or register to post comments

Comment #2

catch

he/him

English

CreditAttribution: catch commented 27 June 2009 at 17:25

Status:

Needs work

» Needs review

File	Size
panels.patch	2.39 KB

Re-roll to remove the $extras variable. While I agree this could do with fixing things up, it's currently holding up other patches which are more important.