In follow-up of a drupal-devel discussion about embedded links in t()-strings:

http://lists.drupal.org/archives/drupal-devel/2004-01/msg00116.html

Here's the patch. All static link captions are now inside the translated text. I also clarified the doxygen for t() a bit.

In the future, please pay attention to this: it's a very annoying/boring task to fix, and the less we have to change existing t() strings, the better.

Please review... I've tried to work methodically and exact, but in such a large patch it's likely that an error slipped in which I didn't notice.

CommentFileSizeAuthor
helplinks.patch148.53 KBSteven
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Dries CreditAttribution: Dries commented

Anyone opposed to this approach/patch? If so, please speak up now.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

As it was discussed on the devel list, this is needed by some languages, so while my native language does not need this, I am not against the patch :) It will also result in less short strings to load, resuting in less memory consumption when normal users visit pages. In case there is some error in the resulting strings, we can fix that later on (I have not checked all the changes for accuracy of course).

Dries’s picture

Dries CreditAttribution: Dries commented

I committed this patch to HEAD. The patch was malformed but I could fix it. Thanks.

Dries’s picture

Dries CreditAttribution: Dries commented
Anonymous’s picture

(not verified) CreditAttribution: commented