Make tabs accessible to users without access to default tab

I support this patch (if it doesn't fail badly).

Hi

This patch applied successfully to drupal 7 CVS
Hunk #1 succeeded at 1648 (offset -6 lines)

Comments administration now appears as a tab as expected after flushing menu cache

I don't believe this adds usability. Its removing 'Comments' from the navigation tree and hiding it under 'Content'. Are comments just classed as content now?

If comments are just part of content, i think the description text needs updating so that the /admin/content page lets a new admin know that comments are hidden away in here too.

This is good because we centralize all content under one hub, however this is on the premise that MDB work gets in and we don't have to mess with the non-prominent garland tabs.

Committed to CVS HEAD. Thanks, catch.

Now someone should create a user that only has privileges to administer comments, but not administer nodes and stuff. The result? No menu item to administer comments.

check http://drupalbin.com/10179 for a solution that works. I need to fix the description and then it becomes a patch.

I think someone should add a test.

edit: the altered description maybe wants to be 'List and edit site comments and the comment approval queue.'

I have changed the hardwired access check to menu_get_item checks. A bit slower... but i doubt performance is a penultimate problem on these pages.

Neither the test nor the patch is perfect but here I offer this way more complete solution.

This needs a generic, clean and elegant fix because this pattern is used throughout many of the mockups in the new IA. Talking to Mark and Leisa, they want to fix the use of tabs and switch the model around. Tabs are views, not actions.

I'm a bit worried about:

+  $items['admin/content/%comment_admin'] = array(
+    'title callback' => 'comment_admin_title',
+    // This works because both every string (but '0') is == TRUE.
+    'access callback' => 'comment_admin_to_arg',
+    'options' => array('alter' => TRUE),
+  );

Given that this will be a very common practice, I'm not sure we want to use these 'tricks' as a pattern throughout Drupal. The patch is pretty undocumented so I'm not 100% yet what it does, but can't we auto-promote the next tab to the default tab, if there is no default tab?

While this might function, I stick by the decision to eliminate the "bubbling" behavior of D5. We should fix up the permissions in the hierarchy if we want users of this page to see a link by default.

yay, bump! :) This maps 100% to my predictions for 2010.

This is still critical due to the IA changes we applied to D7. I won't comment on those anymore, but this particular bug makes certain use-case scenarios impossible in D7, which perfectly worked previously.

Can you summarize the bug/regression or use cases that cannot be accommodated? what is the desired behavior?

Quite simple:

"A moderator, who moderates comments."

Nothing more, nothing less. No "administer nodes" or whatever permission.

In D6 and below, this user had Administer -> Content management -> Comments.

In D7, this functionality would be expected on Administer -> Content. Technically, by auto-adjusting the default local task according to the user's permissions.

The most recent patch on this issue is quite creative, but is also an aggressive hack. I fail to see how a contributed module would be able to override or extend the local tasks for users that only have the "administer comments" permission.

Although badly needed, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time (though that's unlikely).

Only feature requests and tasks can be assigned to D8 for now, because the Drupal 8 tree is not opened yet.

Fortunately, this feels more like a feature request to me.

...

Think this probably can be closed as there hasn't been movement on it for 13 years. Plus there seemed to be some commits already made for it. If still a valid feature request though please reopen updating the issue for how this applies for D10 and up.

Thanks!