Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.SimpleTest has two variables which can be quite handy, but both of which are not visible in any way other then by reading the code.
This patch creates a settings page for the two variables and is in preparation for the verbose mode setting to be provided by #500280: Provide a verbose mode for SimpleTest.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 500292-simpletest-settings.patch | 4.17 KB | boombatower |
| #10 | 500292-simpletest-settings.patch | 4.25 KB | boombatower |
| #1 | 500292-simpletest-settings.patch | 2.45 KB | boombatower |
Comments
Comment #1
boombatower CreditAttribution: boombatower commentedComment #3
boombatower CreditAttribution: boombatower commentedTest slave crapped.
Comment #4
moshe weitzman CreditAttribution: moshe weitzman commentedVery handy.
Comment #6
moshe weitzman CreditAttribution: moshe weitzman commentedComment #7
Dries CreditAttribution: Dries commented- If we're going to accept auth information we should have a username and password field IMO.
- The form descriptions are not really helpful. They don't tell me why authentication is useful, or when it should be configured. They don't tell me why I might want to clean after each test run. I think we need to make those settings more accessible for non SimpleTest experts -- or keep them hidden.
- Shouldn't this live under Site configuration?
Comment #8
boombatower CreditAttribution: boombatower commentedI purely matched SimpleTest variable that is a single field for username/password, I'll split it up on form.
Will add descriptions.
I wasn't sure about it living under site configuration. SimpleTest is a development tool and doesn't effect the overall site so it seemed odd to place it in site configuration. Most development tools have their own special settings and such and this seemed like a clean pattern to keep them out of site configuration.
Since I am starting something new I definitely want opinions...
I'll try and get new patch shortly.
Comment #9
boombatower CreditAttribution: boombatower commentedThis should do the trick.
Please let the hook_uninstall() variable removal be cleaned up in separate issue: #500270: SimpleTest hook_uninstall() does not delete the correct variables
Comment #10
boombatower CreditAttribution: boombatower commentedComment #11
Dries CreditAttribution: Dries commented- Can you put the help text on one line for consistency?
- Where can people fine the [result_id]? The documentation is not telling me that.
- Can we reduce 'simpletest_httpauth_credentials_username' to 'simpletest_username'? Ditto for password.
Otherwise looks good.
Comment #12
boombatower CreditAttribution: boombatower commentedSummary of what this patch does:
simpletest_httpauth_credentialsintosimpletest_usernameandsimpletest_password.simpletest_clear_resultsvariable.Comment #14
boombatower CreditAttribution: boombatower commentedComment #15
Dries CreditAttribution: Dries commentedOK, the latest changes look good. The location of the settings page is OK for now, but could be revisited as part of the new IA. Committed to CVS HEAD.