element_children only returns keys to arrays. that's how fapi is. Adding cruft to protect against broken code was never good and now that I want to convert to ArrayObject it blocks progress (as expected).

CommentFileSizeAuthor
#3 cruft.patch3.66 KBchx
cruft.patch2.69 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented

Oh this got added by the original fapi conversion! That's how it got there and that's how it sneaked in... the dark corners of core.

chx’s picture

chx CreditAttribution: chx commented

grepped around, only aggregator.pages.inc has more of the same.

chx’s picture

chx CreditAttribution: chx commented
Component: user system » base system
FileSize
cruft.patch3.66 KB

And the patch to remove that.

Damien Tournoud’s picture

Damien Tournoud CreditAttribution: Damien Tournoud commented
Status: Needs review » Reviewed & tested by the community

It's never bad to remove some old cruft.

Makes total sense, let's do that.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.