DBTNG the rest [#491556]

When the patches at http://drupal.org/project/issues/search/drupal?text=&assigned=&submitted... are in, there are only a few missing bits and pieces to convert. There are a few things I'm not sure about, but the attached patch will convert almost all of them.

It will currently fail, because the INSERT INTO () FROM patch needs to go in first.

Comment	File	Size	Author
#8	dbtng_convert_remaining5.patch	21.83 KB	Berdir
#8
#7	dbtng_convert_remaining4.patch	21.83 KB	Berdir
#7
#5	dbtng_convert_remaining3.patch	22.3 KB	Berdir
#5
#3	dbtng_convert_remaining2.patch	22.3 KB	Berdir
#3
	dbtng_convert_remaining.patch	27.2 KB	Berdir

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 June 2009 at 20:20

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #2

cafuego CreditAttribution: cafuego commented 23 June 2009 at 05:49

I've addressed some of these (specifically a bunch in system.install) in #497684: system.install incorrectly assumes more sequential IDs

Comment #3

Berdir

German

Switzerland

CreditAttribution: Berdir commented 25 July 2009 at 10:29

Status:

Needs work

» Needs review

File	Size
dbtng_convert_remaining2.patch	22.3 KB

Re-roll, left out the user pieces in system_install(), because the sequences API patch should take care of that.

Comment #4

25 July 2009 at 10:45

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #5

Berdir

German

Switzerland

CreditAttribution: Berdir commented 25 July 2009 at 16:30

Status:

Needs work

» Needs review

File	Size
dbtng_convert_remaining3.patch	22.3 KB

Tiny error fixed...

Comment #6

Damien Tournoud CreditAttribution: Damien Tournoud commented 25 July 2009 at 19:23

Status:

Needs review

» Needs work

Nice job, again! A few issues:

     field_attach_insert($entity_type, $entity);
-    $count = db_result(db_query("SELECT COUNT(*) FROM {{$this->table}}"));
+    $count = db_query("SELECT COUNT(*) FROM {{$this->table}}")->fetchField();
     $this->assertEqual($count, 0, 'Missing field results in no inserts');

^ Those (there are a few of them) are dynamic queries. They *need* to be converted to db_select() ;)

+
+  // Set node type options.
+  variable_set('node_options_forum', array('status'));

^ ?

Comment #7

Berdir

German

Switzerland

CreditAttribution: Berdir commented 28 July 2009 at 12:05

Status:

Needs work

» Needs review

File	Size
dbtng_convert_remaining4.patch	21.83 KB

Re-rolled with the things mentioned by DamZ fixed.

That variable_set() is currently in system_install(), where it imho makes no sense. It was a INSERT-query before but has been converted to variable_set() now. I removed it and leaving this for another issue, as it is not DBTNG-related anymore.