Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Both theme('pager') doesn't return any HTML (and the $globals are 0/1 even if there's two pages), and manually trying to go to a page doesn't work either. Haven't tracked down why yet.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | show_comments_pager.patch | 641 bytes | tic2000 |
| #3 | show_comments_pager.patch | 1.34 KB | tic2000 |
| #2 | show_comments_pager.patch | 1.4 KB | tic2000 |
Comments
Comment #1
catchMarked #26966: Fix comment links when paging is used. postponed on this issue.
Comment #2
tic2000 CreditAttribution: tic2000 commentedThis solves the problem.
I don't know if in the pager logic the $count_query is used, most probably not, but I don't know how to pass it. If I try to use
SelectQueryInterfaceas a chain I get a fatal error. If I try to declare it on a new line it trows an error message, but the pager works.Not very familiar with the new db api and how it should work.
Comment #3
tic2000 CreditAttribution: tic2000 commentedA proper patch. This adds the count query to the pager.
All credit to Berdir, my only merit is that I asked.
Comment #4
tic2000 CreditAttribution: tic2000 commentedA new patch that removes a change that was in the previous patch, but was not needed.
Comment #5
BerdirIt was my input, so I can't rtbc it, but the changes look good and I verified that the fix works.
Comment #6
catchWorks. Tests for this freshly re-rolled so we can watch them fail until this goes in #296483: TestingParty08: paged comments
Comment #7
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD.