Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This is a child task for #422380: Convert all core module to use new static caching API focusing on the simpletest module.
Comment | File | Size | Author |
---|---|---|---|
#16 | 481498-16.patch | 4.18 KB | JamesAn |
#13 | 481498-13.patch | 4.18 KB | JamesAn |
#11 | 481498-simpletest-static.patch | 4 KB | boombatower |
#9 | 481498-simpletest-static.patch | 4 KB | boombatower |
#3 | 481498-3.patch | 4.13 KB | JamesAn |
Comments
Comment #1
JamesAn CreditAttribution: JamesAn commentedA wrapper function as per #422362-20: convert form.inc to use new static caching API was created to reset the static var in file_test_file_scan_callback().
Comment #3
JamesAn CreditAttribution: JamesAn commentedComment #5
boombatower CreditAttribution: boombatower commentedTechnically this is a duplicate of: #348455: Provide a scalable way to ensure a clean testing environment for SimpleTest, but we can just prioritize this one.
Comment #6
boombatower CreditAttribution: boombatower commentedPlease hold off on this patch though, longer standing patch with better cleanup of loading stuff #449198: SimpleTest: Clean up test loading and related API which also adds statics stuff. (just needs committing) [perhaps you want to review]
Comment #7
JamesAn CreditAttribution: JamesAn commentedPostponed on account of #449198: SimpleTest: Clean up test loading and related API. Thanks for the heads up!
I'm not sure about reviewing that large patch... I've never reviewed anything before, much less a large patch of an unfamiliar module.. ^^"
Comment #8
boombatower CreditAttribution: boombatower commentedIssue has been committed.
Comment #9
boombatower CreditAttribution: boombatower commentedI added drupal_static() in checkPermissions(), but I am not sure where to go from there. In order to complete the process setUp() needs to take advantage of drupal_static_reset(), but I am not sure that is the scope of this particular issue.
Comment #11
boombatower CreditAttribution: boombatower commentedSuppose this would be a bad idea (carried over from original) :)
Comment #13
JamesAn CreditAttribution: JamesAn commented+ return files;
should be
+ return $files;
Comment #15
boombatower CreditAttribution: boombatower commentedTest slave crapped.
Comment #16
JamesAn CreditAttribution: JamesAn commentedRerolled.
Comment #17
boombatower CreditAttribution: boombatower commentedLooks good.
Comment #18
Dries CreditAttribution: Dries commentedSmall code style issue:
+ } else {
. Fixed that and committed to CVS HEAD.