Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
It's silly that when you enable the Forum module there's no visual indication that anything has changed.
This should be a one-liner patch to remove the menu item's 'type' property.
Comment | File | Size | Author |
---|---|---|---|
#7 | forum_menu.patch | 579 bytes | Shawn DeArmond |
#4 | forum-menu.patch | 621 bytes | andypost |
#3 | forum_menu.patch | 551 bytes | Shawn DeArmond |
#1 | forum_menu.patch | 563 bytes | Shawn DeArmond |
Comments
Comment #1
Shawn DeArmond CreditAttribution: Shawn DeArmond commentedHere's your one-liner patch.
It's my first core patch. I thought I'd start small. Please be kind if I did something wrong.
Shawn
Comment #3
Shawn DeArmond CreditAttribution: Shawn DeArmond commentedDang it! I think I know what I did. Let's try this again.
Comment #4
andypostAnother try :)
Comment #5
webchick@Shawn DeArmond: that was actually perfect. The *only* problem is that the patch needs to be rolled from your "root" Drupal directory (so where INSTALL.txt, etc. are).
Wanna give it one more shot?
@andypost: You are not a novice. ;)
Comment #6
andypost@Shawn DeArmond try to use cvs diff -u as key - patch format should be unified
Comment #7
Shawn DeArmond CreditAttribution: Shawn DeArmond commentedSo I'm using Komodo to do these patches. When I run a diff on a single file, it rolls the patch based on only that file. Since my "Project" is the root Drupal directory, that directory is not available to run a diff off of. Very inconvenient. I created a new project file one directory shallower:
drupal7/drupal_head/modules/forum/.....
Now I can run a diff off of the drupal_head directory. Here's the patch it spit out. It should work this time.
Thanks for your help and patience.
Shawn
Comment #8
Shawn DeArmond CreditAttribution: Shawn DeArmond commentedKomodo does use "-u" when doing a diff. It says it does anyway.
Comment #9
webchickIt does -u indeed. I think andypost meant -p, which will give you some extra context as to what function those lines came from. But I have no idea how to do diffs with Komodo. :\ It's too bad it's such a pain. :( It might be worth looking into setting up a command line environment because it's *much* easier. Drop by #drupal if you ever need a hand.
Patch looks good, testing bot is happy, committed to HEAD! Thanks a lot, Shawn! :D
Comment #10
Shawn DeArmond CreditAttribution: Shawn DeArmond commentedCool! Thanks! Yeah, I've used CVS from the command line before, but I'm trying to see if Komodo can do some of the work for me. It does some, but it looks like it's back to the good-ol' command line for some things too.
Thanks again!
Shawn