It's silly that when you enable the Forum module there's no visual indication that anything has changed.

This should be a one-liner patch to remove the menu item's 'type' property.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shawn DeArmond’s picture

Status: Active » Needs review
FileSize
563 bytes

Here's your one-liner patch.

It's my first core patch. I thought I'd start small. Please be kind if I did something wrong.

Shawn

Status: Needs review » Needs work

The last submitted patch failed testing.

Shawn DeArmond’s picture

FileSize
551 bytes

Dang it! I think I know what I did. Let's try this again.

andypost’s picture

Status: Needs work » Needs review
FileSize
621 bytes

Another try :)

webchick’s picture

@Shawn DeArmond: that was actually perfect. The *only* problem is that the patch needs to be rolled from your "root" Drupal directory (so where INSTALL.txt, etc. are).

Wanna give it one more shot?

@andypost: You are not a novice. ;)

andypost’s picture

@Shawn DeArmond try to use cvs diff -u as key - patch format should be unified

Shawn DeArmond’s picture

FileSize
579 bytes

So I'm using Komodo to do these patches. When I run a diff on a single file, it rolls the patch based on only that file. Since my "Project" is the root Drupal directory, that directory is not available to run a diff off of. Very inconvenient. I created a new project file one directory shallower:
drupal7/drupal_head/modules/forum/.....

Now I can run a diff off of the drupal_head directory. Here's the patch it spit out. It should work this time.

Thanks for your help and patience.

Shawn

Shawn DeArmond’s picture

Komodo does use "-u" when doing a diff. It says it does anyway.

webchick’s picture

Status: Needs review » Fixed

It does -u indeed. I think andypost meant -p, which will give you some extra context as to what function those lines came from. But I have no idea how to do diffs with Komodo. :\ It's too bad it's such a pain. :( It might be worth looking into setting up a command line environment because it's *much* easier. Drop by #drupal if you ever need a hand.

Patch looks good, testing bot is happy, committed to HEAD! Thanks a lot, Shawn! :D

Shawn DeArmond’s picture

Cool! Thanks! Yeah, I've used CVS from the command line before, but I'm trying to see if Komodo can do some of the work for me. It does some, but it looks like it's back to the good-ol' command line for some things too.

Thanks again!
Shawn

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.