New tests:

  • that the Recent Poll block outputs the block layout rather than page layout.
  • that users can vote on polls via the block
  • that the 'older polls' link in the recent poll block works.
  • that node is output correctly, including 'Cancel your vote' button appearing
  • that only users with appropriate permission can cancel their votes
  • that the 'poll' page contains the correct data.
  • that polls can be edited
  • the opening / closing of polls - ensuring block doesn't appear when poll is closed, and neither do the 'Vote' / 'Cancel your vote' buttons, and that the poll status is updated correctly on 'poll' page.

Dependent on tickets #474302: Poll module fixes - due to recent api changes and #372650: Poll node is not displayed when poll block is displayed as well - these tests should fail without those changes.

Cheers,
Stella

CommentFileSizeAuthor
#5 poll_tests.patch9.51 KBstella
#1 poll_tests.patch8.84 KBstella
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stella’s picture

stella CreditAttribution: stella commented
FileSize
poll_tests.patch8.84 KB

of course it helps if I attach the file :)

Status: Needs review » Needs work

The last submitted patch failed testing.

chx’s picture

chx CreditAttribution: chx commented

asserting a themed something (like t(%) leading to theme('placeholder')) will break if the default theme is not Garland and it overrides theme(placeholder). So ... something better is needed. Other than that, nice test.

Dries’s picture

Dries CreditAttribution: Dries commented
Issue tags: +Favorite-of-Dries

Tagging

stella’s picture

stella CreditAttribution: stella commented
FileSize
poll_tests.patch9.51 KB

Patch re-roll that addresses the % assertion issue chx identified.

lilou’s picture

lilou CreditAttribution: lilou commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

stella’s picture

stella CreditAttribution: stella commented

Tests are going to fail until #372650: Poll node is not displayed when poll block is displayed as well is committed

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs work » Postponed

More obvious status.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Postponed » Needs review

Let's try that again, test bot.

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs work » Needs review

hey! :P

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Tests passed

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

These all look good.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Favorite-of-Dries

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Favorite-of-Dries

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.