Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Leave it to the unstable release when I announce vertical tabs to find this bug. Sigh. :(
Comment | File | Size | Author |
---|---|---|---|
#11 | vertical-tabs.css_.patch | 576 bytes | tic2000 |
#4 | vertical-tabs.css_.patch | 549 bytes | tic2000 |
Comments
Comment #1
webchickThe commit that broke this happened sometime between 5/21 and 5/22:
Comment #2
webchickGot it in one. ;)
#428744: Make the main page content a real block
Comment #3
Gábor HojtsyReproduced the same problem in Safari and Firefox. Thought it is my machine. Looks like it is not only me :(
Comment #4
tic2000 CreditAttribution: tic2000 commentedSince the issue pointed by @webchick made the main content a block, the main content is wrapped now in a div with the class .block. That made that the css for
.vertical-tabs-list
was overwritten byin style.css.
I don't know if this is the drupal way to fix the problem, but here is a patch that just point the style more precisely so it can't be overwritten by
.block ul
I think this is a drupal.css problem, not javascript.
Tested in FF3, IE7 and Safari.
Comment #5
Gábor HojtsyUsing a more specific selector should be fine. (Did not review the actual patch.)
Comment #6
tobiasbworks 1+
Comment #7
oriol_e9gComment #8
tic2000 CreditAttribution: tic2000 commentedIMHO all the css inside there should use more specific CSS selectors. After all I don't think those classes are meant as general classes (like .error, .clearfix, etc.)
This way it would prevent other themes, modules to accidentally break the layout again.
Comment #9
Sivaji_Ganesh_Jojodae CreditAttribution: Sivaji_Ganesh_Jojodae commentedThis patch works fine in FF3.
Comment #10
catchThe patch works but it needs to be re-rolled without windows line breaks.
I think we should add a followup issue to look at making all these selectors more specific, but makes sense to just fix the actual bug here.
Comment #11
tic2000 CreditAttribution: tic2000 commentedI hope the line breaks are ok now
Comment #12
tic2000 CreditAttribution: tic2000 commentedComment #13
catchApplies fine now, fixes the bug. RTBC.
Comment #14
webchickWow, awesome! Thanks SO much for the quick turnaround on this, tic2000! :D
Committed to HEAD. Yay! :) Thanks, folks!
Comment #15
tic2000 CreditAttribution: tic2000 commentedI opened a follow-up issue here #474242: Use more specific selectors in vertical-tabs.css so we change the css for all the .vertical-tabs-list css rules