Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We are testing the error/exception handler in common.test currently. Explicitly referencing line numbers in system_test.module. If any lines above the expected line number are changed, the error handler test fails.
Let's make it pass more often.
This is critical, because it breaks #345118: Performance: Split .module files by moving hooks.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | drupal-error_2.patch | 15.92 KB | mr.baileys |
| #4 | drupal-error_1.patch | 14.48 KB | mr.baileys |
| #1 | drupal-error.patch | 14.59 KB | sun |
| drupal-error.patch | 14.59 KB | sun | |
Comments
Comment #1
sunComment #2
sunI need help here, because I have no clue why the tests are failing.
Comment #4
mr.baileysLooks like callback & function names mismatched in error_test.module, and the module was returning "page not found" instead of actual error information.
re-rolled with matching callback/function names
Comment #5
Damien Tournoud CreditAttribution: Damien Tournoud commentedDear testbot, please mark as RTBC if the patch comes back clean.
Comment #7
mr.baileysSome additional mismatched names in assertions & paths (system_test_* instead of error_test_*), which I missed because I only ran the system tests, not the simpletest tests.
re-rolled.
Comment #8
sunYay! Awesome! Thank you, mr.baileys!
Comment #9
webchickCool. Committed to HEAD!