Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I've just spent hours trying to find out where the extra slash after my domain came from. Please specify in the help/info text for the "Language domain" field that there should be no trailing slash.
Comment | File | Size | Author |
---|---|---|---|
#9 | language-domain-form-452244-09.patch | 2.37 KB | jhedstrom |
#9 | language-domain-form-452244-09-TEST-ONLY.patch | 1.11 KB | jhedstrom |
Comments
Comment #1
Jose Reyero CreditAttribution: Jose Reyero commentedThis is Drupal core.
Comment #2
Gábor HojtsyIt should also validate for it IMHO.
Comment #3
jhedstromWell, this no longer is allowed, but the following exception is thrown when adding a trailing slash:
Comment #4
jhedstromThis fixes the fatal error, and adds a mention of not using a trailing slash to the error message.
Comment #5
mmatsoo CreditAttribution: mmatsoo as a volunteer commentedComment #6
mmatsoo CreditAttribution: mmatsoo as a volunteer commentedTested patch and it worked as expected. Fatal error gone and text added to tell user not to use trailing slash.
Comment #7
alexpottLooks like we should have a test for this given
Recoverable fatal error: Object of class Drupal\Core\Language\Language could not be converted to string
.Comment #8
jhedstromI'll write a test.
Comment #9
jhedstromThis adds a test to ensure the form properly detects invalid domains.
Comment #11
Gábor HojtsyLooks good to me.
Comment #12
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed c471f0f and pushed to 8.0.x. Thanks!
Comment #14
Gábor Hojtsy