Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The current "Who's New" block is not completely accurate as it displays users who have signed up but have never logged in. A frequent reason for this is that the user intentionally/unintentionally supplied an incorrect e-mail addresses during signup etc. etc.
Simple patch attached.
Thanks
-K
Comment | File | Size | Author |
---|---|---|---|
#3 | whosnew.png | 6.46 KB | Zen |
user.module_29.patch | 883 bytes | Zen | |
Comments
Comment #1
Dries CreditAttribution: Dries commentedI guess this is debatable. If you sign up, but are not logged on, you're online, not?
Comment #2
Zen CreditAttribution: Zen commentedThis is for the Who's *new* block as opposed to who's *online*, and addresses the case when someone signs up but hasn't _ever_ logged in. As soon as they log in even once, they will be eligible for the who's new block as the access field is set.
The basic issue is that failed/spam signups where erroneous/fake e-mails are used are listed as _new_ users, when they aren't, as they haven't completed the sign-up process i.e. they haven't logged in with their mailed password.
Hope that made sense :)
Thanks
-K
Comment #3
Zen CreditAttribution: Zen commentedThe attached screenshot is an example of a regular occurence of this issue.
-K
Comment #4
m3avrck CreditAttribution: m3avrck commentedZen, excellent catch! I agree 100%, many spam bots try to create accounts but because they never log in, those accounts just sit there and they *shouldn't* be considered "who's new" till they have at least logged in once succesfully, confirming their account. Patch looks great, RTC!
Comment #5
markus_petrux CreditAttribution: markus_petrux commented+1
/me likes the idea too ;-)
Comment #6
Dries CreditAttribution: Dries commentedIf both blocks needs fixing, I guess we need a new patch?
Comment #7
m3avrck CreditAttribution: m3avrck commentedDries, I don't think the 'who's online' block is wrong, it was just the 'who's new' ... a user should be appear correctly in the 'who's online' because they'll have logged in by then.
Issue with 'who's new' is that anyone can create an account, but if you don't log in to that account, you should't appear in the 'who's new' box... maybe that acconut was created by a spambot or a fail attempt, but a user shouldn't be considered new until they log in.
Comment #8
Zen CreditAttribution: Zen commentedFor some context, this is the block of code affected - i.e. the "Who's new" block. "Who's online" doesn't come into the picture at all and is totally unrelated to this issue.
Thanks for the speedy reviewing :)
-K
Comment #9
Dries CreditAttribution: Dries commentedCommitted to HEAD. Thanks.
Comment #10
Zen CreditAttribution: Zen commented