Typo in block.module. New permission is set as: 'use PHP for block visibility' but on line 360, access check is: $access = user_access('Use PHP for block visibility');

Access check is case sensitive, this patch fixes that.

CommentFileSizeAuthor
#2 block.module_13.patch2.39 KBm3avrck
#1 block.module_12.patch2.27 KBm3avrck
block.module_11.patch659 bytesm3avrck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Title: Typo in new PHP permission » Typo in new PHP permission and wrong description
FileSize
block.module_12.patch2.27 KB

Here's a better patch, it also prevents the PHP help text from being shown if the user doesn't have that permission (just like the option is hidden).

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
FileSize
block.module_13.patch2.39 KB

And the best patch, don't display empty fieldsets if the user doesn't have the PHP permission and one has already been set, usability fix.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Fixed » Closed (fixed)