InsertQuery_mysql: Don't execute insert query without values [#432128]

In contrast to the default insert query, InsertQuery_mysql currently creates a SQL syntax error when execute() is called without any values. See #302412: DB TNG: Taxonomy.module.

Because InsertQuery uses foreach to loop over the values, this can't happen there.

Patch adds a simple check to return NULL if no values are set.

Comment	File	Size	Author
#2	insert_no_values2.patch	3.71 KB	Berdir
#2
	insert_mysql_no_values.patch	620 bytes	Berdir

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

13 April 2009 at 11:10

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #2

Berdir

German

Switzerland

CreditAttribution: Berdir commented 13 April 2009 at 19:20

Status:

Needs work

» Needs review

File	Size
insert_no_values2.patch	3.71 KB

Ok, I was wrong, all dbms need the check and every of them overwrites execute() so I have to add those lines 4 times :)

There are two checks which are executed in every execute() implementation, maybe they could be moved to an own function.

Comment #3

Crell CreditAttribution: Crell commented 14 April 2009 at 14:35

Status:

Needs review

» Reviewed & tested by the community

The different execute() routines are not that similar, I think, so I don't know if it's worth generalizing bits of them. Either way that's for another patch to do internal cleanup. This one looks good. Thanks!