Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.yched noted back in #323112: Vertical Tabs that Anonymous is not properly getting replaced:
Might also be worth putting some validation for the date? Currently I can type in:
I imagine I can do similar things elsewhere, too.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 431300-nodejs-authoredby-D7.patch | 1.66 KB | dmitrig01 |
| #13 | 431300-nodejs-authoredby-D7.patch | 769 bytes | dmitrig01 |
| #9 | 431300-nodejs-authoredby-D7.patch | 771 bytes | Dave Reid |
| #8 | vt-date-2.patch | 833 bytes | mgifford |
| #2 | vt-date.patch | 641 bytes | kkaefer |
Comments
Comment #1
kkaefer CreditAttribution: kkaefer commented*subscribe*
Comment #2
kkaefer CreditAttribution: kkaefer commentedThis patch validates the date and uses 'Anonymous' if the user textfield is empty.
Comment #3
kkaefer CreditAttribution: kkaefer commentedThe 'validation' function also allows dates past the 31st of a month, but since we're not doing hard validation I don't think this is a concern.
Comment #4
dmitrig01 CreditAttribution: dmitrig01 commentedLet's fix this for real - let the user enter a human-readable date and find some way to let the user select either Anonymous or an auth'd user. Additionally, for this patch, Anonymous username is a variable (I forget what)
Comment #5
moshe weitzman CreditAttribution: moshe weitzman commentedJavascript validation is a bigger issue than this issue, IMO. Also, lets use descriptive titles. Lets just fix the bug.
Comment #6
Bevan CreditAttribution: Bevan commentedtagging
Comment #8
mgiffordI haven't fixed the bug, but the patch needed to be updated.
Comment #9
Dave ReidPrevious patch had some of the validation code left in. Revised patch that just fixes the bug. This is also the same code we're now using with the D6 backport of Vertical Tabs.
Comment #10
Dave ReidComment #11
Dave ReidFYI committed this to the backport contrib module.
Comment #12
MichaelCole CreditAttribution: MichaelCole commented#9: 431300-nodejs-authoredby-D7.patch queued for re-testing.
Comment #13
dmitrig01 CreditAttribution: dmitrig01 commentedI know that now it's getting really nit-picky but let's optimize and use one var statement instead of two.
Comment #14
joachim CreditAttribution: joachim commentedLooks good.
But this should be using the setting for Anonymous user name at admin/config/people/accounts.
Comment #15
dmitrig01 CreditAttribution: dmitrig01 commentedGood point.
Comment #16
jzacsh CreditAttribution: jzacsh commentedPatch works, name changes appropriately now.
Comment #17
Dries CreditAttribution: Dries commentedLooks good. Committed to CVS HEAD. Thanks.