Guarantee one database update per request [#43002]

The page timer used to check how long updates have been running uses the ammount of time from the start of the request, so there is already time on the clock by the time it is checked the first time, currently just before the first update is performed. If it has taken more than a second already, then the updates are completely skipped and the unchanged status is sent back, causing an infinite loop until the code execution becomes faster.

This patch moves the time checking to the end of the loop which guarantees at least one update is performed.

Comment	File	Size	Author
#3	update.php_4.diff	932 bytes	drumm
#3
	update.php_3.diff	932 bytes	drumm

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hunmonk CreditAttribution: hunmonk commented 2 January 2006 at 07:19

tested, works great. before this patch i was having trouble with my database updates hanging--after applying things worked beautiful. +1

Comment #2

Dries CreditAttribution: Dries commented 2 January 2006 at 08:26

Doesn't that break always trigger now? Shouldn't that be greater than?
(How about we remove the timing stuff alltogether and do one update function at a time?)

Comment #3

drumm

he/him

NY, US

CreditAttribution: drumm commented 2 January 2006 at 20:51

File	Size
update.php_4.diff	932 bytes

Good catch. New patch attached.

On a reasonably fast server, many updates can be done in a second. My 4.6 to 4.7 updates usually got done in two or three batches. This saves a lot of time since a round trip HTTP request takes a lot of time. The whole process becomes faster if we do as many updates as possible in one batch. The time is as low as one second to provide reasonably frequent feedback to show that progress is being made.