Text between <code> tags is displayed in a very small font size. The attached patch increases this size to 150%, making the code look identical in size to regular text. Tested in Safari 3.2.1 and Firefox 3.0.8 (Mac).

CommentFileSizeAuthor
#15 421076_code_font-size_seven.png15.13 KBstBorchert
#10 421076_code_font_size-10.patch599 bytesstBorchert
#9 font_size_code_before.png2.05 KBstBorchert
#9 font_size_code_after.png1.91 KBstBorchert
#4 code_font_size_02.patch809 bytesXano
#3 code_font_size_01.patch723 bytesXano
code_font_size_00.patch705 bytesXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

subscribing

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs review » Needs work

Short notice: this needs a per-theme approach.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Component: base system » Garland theme
Status: Needs work » Needs review
FileSize
code_font_size_01.patch723 bytes
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
FileSize
code_font_size_02.patch809 bytes

Follow-up that also increases font-size for PRE and KBD elements.

Dries’s picture

Dries CreditAttribution: Dries commented

Do you have an explanation for why we need to set it to 150% rather than have it magically work at the default size? I guess I could fire up Firebug and find out ...

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

The default font size of these elements is smaller than the font size of the surrounding text, making the code hard to read. This patch makes all font sizes equal.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

Hm. Why 150% ?

Usually, I have this default snippet in all of my projects' themes:

code, pre, kbd {
  font-family: "Courier new", Courier;
  font-size: 100%;
  color: #000;
}

Whereas a popular browser CSS reset snippet does:

pre,code { font: 115% monospace; }

...which is equally only slightly larger than 100%.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Needs work

This either needs a comment or a different size.

stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert commented
FileSize
font_size_code_after.png1.91 KB
font_size_code_before.png2.05 KB

I'm ok with 115%.
The first screenshot shows the actual size and the second with size set to 115%.

stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert commented
Status: Needs work » Needs review
FileSize
421076_code_font_size-10.patch599 bytes

Re-roll with font-size: 115%;.

Status: Needs review » Needs work

The last submitted patch failed testing.

deekayen’s picture

deekayen CreditAttribution: deekayen commented
Status: Needs work » Needs review

infant bot doesn't know how to test patches properly yet

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented
Status: Needs review » Reviewed & tested by the community

Marking this RTBC, tried it out, and it looks good.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

Wow, this issue still around? - definitely.

Though - shouldn't this be applied to all core themes? (not limited to Garland)

stBorchert’s picture

stBorchert
he/him
Primary language German
CreditAttribution: stBorchert commented
Assigned: Xano » Unassigned
FileSize
421076_code_font-size_seven.png15.13 KB

Seven doesn't need this modification because its looking good (see screenshot).

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Quick fix

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.