Remove unused parameter from comment_admin_overview [#415250]

The comment_admin_overview() function (in comment.admin.inc) takes a first parameter called $type. This parameter is not used. It's actually DOCUMENTED as "not used" in the comment's doxygen block. So... why is it still there?

Attached patch removes the parameter, the doxygen comment, and the argument (from the one spot where the function is called). No-brainer.

Comment	File	Size	Author
#6	415250-better-doc.patch	1.11 KB	jhodgdon
#6
#4	415250.patch	885 bytes	R.Muilwijk
#4
#2	comment_module_unneeded_arg.patch	1.23 KB	Jaza
#2
	comment_module_unneeded_arg.patch	1023 bytes	Jaza

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 March 2009 at 05:25

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #2

Jaza CreditAttribution: Jaza commented 27 March 2009 at 05:26

Status:

Needs work

» Needs review

File	Size
comment_module_unneeded_arg.patch	1.23 KB

Oops, the parameter can also be removed from comment_admin().

Comment #3

27 March 2009 at 05:35

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Comment #4

R.Muilwijk CreditAttribution: R.Muilwijk commented 21 June 2010 at 23:22

Status:

Needs work

» Needs review

File	Size
415250.patch	885 bytes

Reroll with small logic fix. Also did a grep to find more instances but found nothing.

Comment #5

R.Muilwijk CreditAttribution: R.Muilwijk commented 24 June 2010 at 12:04

Assigned:

Jaza

» Unassigned

Comment #6

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 24 June 2010 at 16:23

File	Size
415250-better-doc.patch	1.11 KB

This patch brings the doc up to standards.

As a note, it appears that the unused argument to comment_admin_overview() was removed earlier on some other issue, but whoever did that didn't remove it from the calling function. So the code in the above patch is correctly removing it.