setting profile field to hidden does not remove it from the user edit form [#41509]

Comment	File	Size	Author
#12	profile.module_16.patch	6.85 KB	rkerr

#10	profile.module_15.patch	6.13 KB	yched

#7	profile_hidden.diff	2.32 KB	munga

#1	profile.diff	6.87 KB	munga

Comment #1

munga CreditAttribution: munga commented 1 January 2006 at 04:35

File	Size
profile.diff	6.87 KB

The attached patch should fix the problem ...

Log in or register to post comments

Comment #2

munga CreditAttribution: munga commented 1 January 2006 at 04:40

Reg that pacth I've just submitted ...

I'm not sure if it's the right way to solve the problem and
I haven't managed to make the category disappear if all fields in that
category are hidden ... I think the category tab is set in user.module.

Log in or register to post comments

Comment #3

Steve Dondley CreditAttribution: Steve Dondley commented 4 January 2006 at 15:57

I don't understand this bug report. Why should a hidden or private field be removed from the user edit form? User's should always be able to edit these fields regardless of the "Visibility" setting.

Log in or register to post comments

Comment #4

merlinofchaos CreditAttribution: merlinofchaos commented 4 January 2006 at 16:04

Because 'hidden' fields are not meant to be user editable, but should only be edited by admins, modules or themes.

It's useful for things like Titles that admins can give users. I don't want users editing their titles if they have meaning, for example!

Log in or register to post comments

Comment #5

Wesley Tanaka CreditAttribution: Wesley Tanaka commented 4 January 2006 at 16:26

Status:

Active

» Needs review

what #4 says

setting patch status for patch in #1

Log in or register to post comments

Comment #6

Steve Dondley CreditAttribution: Steve Dondley commented 5 January 2006 at 02:01

Status:

Needs review

» Needs work

Code for form elements should span several lines instead of being bunched onto one.

Log in or register to post comments

Comment #7

munga CreditAttribution: munga commented 5 January 2006 at 02:44

File	Size
profile_hidden.diff	2.32 KB

new patch attached. This one contains only the small patch for the hidden files (and
this time in the correct order). I left any other modifications out.

p

Log in or register to post comments

Comment #8

yched CreditAttribution: yched commented 25 January 2006 at 18:32

I'd like very much this bug to be fixed :-)
Could you provide an update of your patch against current head ?

Log in or register to post comments

Comment #9

darius CreditAttribution: darius commented 25 January 2006 at 20:36

Title:

setting profile field to hidden or private does not remove it from the user edit form

» setting profile field to hidden does not remove it from the user edit form

The issue is real (I just verified this with the latest CVS version), but the patch does not apply cleanly anymore. Also, the related issue could be addressed here, too: admins SHOULD see the hidden fields in VIEWING user profile (currently, the issue only addresses what happens in EDITING user profile).

Darius

P.S. I removed "private" from the title because this only concerns "hidden" fields.