They have no padding or margin, so are actually leftwards of the radio buttons themselves. Screenshot attached.

yuck

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mr.baileys’s picture

FileSize
96.1 KB

What browser are you using? When I visit the same page using a recently checked out copy, the descriptions are more or less indented as they should (see screenshot, Firefox 3 on windows)

catch’s picture

Sorry I should have mentioned that this is with theme('indentation') removed from comment_form_alter(). We shouldn't need to add nasty empty divs there to get around them looking like crap.

stBorchert’s picture

This would only be possible if the surrounding divs get an additional class representing the item type, e.g.

<div id="edit-filters-filter/2-wrapper" class="form-item form-checkbox">
  <label for="edit-filters-filter/2" class="option"><input type="checkbox" class="form-checkbox" .../> Convert URLs into links</label>
  <div class="description">Turns web and e-mail addresses into clickable links.</div>
</div>

If this is done it shouldn't be a problem to style the description of single element types.

stBorchert’s picture

Status: Active » Postponed

Postponed until #43493: FAPI: Add name/type as CSS class for form elements gets in.
If this issue is fixed this one can easily be done with

.form-checkbox .description, 
.form-radio .description {
  margin-left: 2.5em;
}
stBorchert’s picture

Status: Postponed » Needs review
FileSize
592 bytes

Just noticed the issue was still open ...
Here's the (very simple) patch.

stBorchert’s picture

Re-roll with indentation of 2.4em. This fits better.

eigentor’s picture

Status: Needs review » Reviewed & tested by the community

Checked: wonderful. This fits on point.

webchick’s picture

Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs work

Hm. I'm not sure this is any longer valid? The descriptions of the comment settings in the vertical tabs on the node add form look fine to me under Garland. This patch, otoh, ends up wildly skewing them to the right. They are a bit off in Seven, but it strikes me that these ought to maybe be fixed there instead.

Could you take another look?

Also, because this changes no APIs, this is something that we can kick to post-code freeze.

stBorchert’s picture

Status: Needs work » Needs review
FileSize
2.99 KB

Ah, I see. comment.module is using theme('indentation') to indent the description. Catch noted this before but I forgot about it.
I removed this theme-calls from comment.module and now it looks good.
(btw.: there are no further calls of theme_indentation so we can actually remove it)

I don't "installed" Seven for now but this could be a follow up issue (if you like).

catch’s picture

stBorchert, please double check theme('indentation') doesn't get called indirectly via drupal_render() - I think it's still used by drag and drop but might not be called directly any more. If it really can be removed, this issue should be marked critical instead of minor :p

stBorchert’s picture

Ok, theme_indentation might be removed in an other issue. I forgot to update the code base so here is a new patch with fixed descriptions in "Seven".

stBorchert’s picture

Re-roll (.form-item-checkbox is now .form-type-checkbox).

dawehner’s picture

+++ themes/seven/style.css	31 Aug 2009 20:53:52 -0000
@@ -537,6 +537,11 @@ div.form-item div.description {
+
+

there is a line to much ;)

This review is powered by Dreditor.

stBorchert’s picture

Updated patch and removed the blank line.
Thanks, dereine! :-)

catch’s picture

Status: Needs review » Reviewed & tested by the community

Looks great.

Dries’s picture

Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.