Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
They have no padding or margin, so are actually leftwards of the radio buttons themselves. Screenshot attached.
Comment | File | Size | Author |
---|---|---|---|
#14 | 412030_item_description-14.patch | 3.43 KB | stBorchert |
#12 | 412030_item_description-12.patch | 3.51 KB | stBorchert |
#11 | 412030_item_description-11.patch | 3.54 KB | stBorchert |
#9 | 412030_item_description-9.patch | 2.99 KB | stBorchert |
#6 | 412030_item_description-6.patch | 647 bytes | stBorchert |
Comments
Comment #1
mr.baileysWhat browser are you using? When I visit the same page using a recently checked out copy, the descriptions are more or less indented as they should (see screenshot, Firefox 3 on windows)
Comment #2
catchSorry I should have mentioned that this is with theme('indentation') removed from comment_form_alter(). We shouldn't need to add nasty empty divs there to get around them looking like crap.
Comment #3
stBorchertThis would only be possible if the surrounding divs get an additional class representing the item type, e.g.
If this is done it shouldn't be a problem to style the description of single element types.
Comment #4
stBorchertPostponed until #43493: FAPI: Add name/type as CSS class for form elements gets in.
If this issue is fixed this one can easily be done with
Comment #5
stBorchertJust noticed the issue was still open ...
Here's the (very simple) patch.
Comment #6
stBorchertRe-roll with indentation of
2.4em
. This fits better.Comment #7
eigentor CreditAttribution: eigentor commentedChecked: wonderful. This fits on point.
Comment #8
webchickHm. I'm not sure this is any longer valid? The descriptions of the comment settings in the vertical tabs on the node add form look fine to me under Garland. This patch, otoh, ends up wildly skewing them to the right. They are a bit off in Seven, but it strikes me that these ought to maybe be fixed there instead.
Could you take another look?
Also, because this changes no APIs, this is something that we can kick to post-code freeze.
Comment #9
stBorchertAh, I see. comment.module is using
theme('indentation')
to indent the description. Catch noted this before but I forgot about it.I removed this theme-calls from comment.module and now it looks good.
(btw.: there are no further calls of
theme_indentation
so we can actually remove it)I don't "installed" Seven for now but this could be a follow up issue (if you like).
Comment #10
catchstBorchert, please double check theme('indentation') doesn't get called indirectly via drupal_render() - I think it's still used by drag and drop but might not be called directly any more. If it really can be removed, this issue should be marked critical instead of minor :p
Comment #11
stBorchertOk,
theme_indentation
might be removed in an other issue. I forgot to update the code base so here is a new patch with fixed descriptions in "Seven".Comment #12
stBorchertRe-roll (
.form-item-checkbox
is now.form-type-checkbox
).Comment #13
dawehnerthere is a line to much ;)
This review is powered by Dreditor.
Comment #14
stBorchertUpdated patch and removed the blank line.
Thanks, dereine! :-)
Comment #15
catchLooks great.
Comment #16
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks.