user-picture.tpl.php should not return an empty div

and let the bot check it out....

another try with white space fix

FINALLY, lol. OK, this is tiny, works, and passes testbot. Ready to go.

Committed to CVS HEAD. Thanks.

Strait backport

I think you mean this. "patch (to be ported)" means someone needs to write a backport which it looks like you already did. :)

That said, in D6 this seems like it might break themes that are already used to this behaviour. Not sure.

+1 for this commit.

There really isn't any way that this could break a theme to get this fixed. If they really need an empty div for some reason then they can always create one based on $picture being NULL. To not fix it requires acrobatic theming (or php) to work around it.

I'm running Drupal 6.15 (and 6.14) and I'm having the same problem. In my node-blog.tpl.php file I conditionally test $picture for content. if there is content I create a division blog-picture. The css for blog-picture contains float:left and some right/left margin so that the profile picture is on the left and the blog floats around it. If there is no picture, I still get the margin spaces. Obviously, this code would not run if $picture is empty, but even if there is no profile picture, $picture contains:

      <span id="thmr_12" class="thmr_call">
  <div class="picture">
  </div>
</span>

so the space is created. I would prefer $picture to be empty if there is no profile picture.

It seems that theme.inc's template_precess_node function themes $variable['picture'] irregardless of the variable's content. Thus if there is no profile picture, the function produces the span and div tags and stores them in $picture.

I modified theme.inc line 1941 to add the IF to conditionally theme 'picture':

   if ($variables['picture']) {$variables['picture'] = theme_get_setting('toggle_node_user_picture') ? theme('user_picture', $node) : '';};

Before this line is executed, $variables['picture'] contains the file location, after the call, it contains the themed picture. If ther is no picture, then $variables['picture'] is empty, and stays empty.

I'm new to this patching process. Attached is a patch I created with netbeans.

Best wishes to all,
Bob

#22 read more about http://drupal.org/coding-standards

This issue is about removing empty div if no picture assigned for user, so _preprocess stage make no sense at all

EDIT: dont forget about default picture!

re:23 Hi Andypost
Sorry for over compacting the code. Not sure if that was your first point, but I can watch myself on that one.

I understand that the issue of this thread is to prevent generating an empty div. And, I am trying to do that in my blog node template file. The problem I see is that when the blog's owner does not have a profile picture, $picture in node-blog.tpl.php contains html wrapper tags, ONLY wrapper tags. So, if I'm going to test for the emptiness of $picture, it needs to be supplied to node-blog.tpl.php empty. With the best of my knowledge and ability, I routed it down to the preprocess function, where, it seems, an empty $picture gets themed. As I have been thinking about it, I'm kinda wondering why, in general, theme() would even wrap an empty input. then again, why would you call theme() with an empty variable...

Good point about the default picture, I did not test that condition. I could easily be wrong, but I would expect the default picture's file specification be placed in $picture before the theme call.

Sorry if I'm missing the boat here, but after having to modify code that seemed errant, I felt obliged to report it.
Bob

The last submitted patch worked for me.