cache_clear_all documentation
http://api.drupal.org/api/function/cache_clear_all/6

says that cid is treated as a substring if $wildcard = TRUE

It would probably be more precise to say that cid is treated as a prefix

CommentFileSizeAuthor
#7 409994-D6_0.patch789 bytesjhodgdon
#6 409994-D6.patch797 bytesWesley Tanaka
#5 409994-D6.patch747 bytesWesley Tanaka
#1 409994.patch538 bytesWesley Tanaka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
FileSize
409994.patch538 bytes
MGParisi’s picture

MGParisi CreditAttribution: MGParisi commented
Status: Active » Fixed

Seems Applied to me!

Fixed

add1sun’s picture

add1sun CreditAttribution: add1sun commented
Project: Documentation » Drupal core
Version: 6.x-1.x-dev » 6.x-dev
Component: Correction/Clarification » documentation
Status: Fixed » Needs review

Hm, the page still refers to it as a substring, unlike what the patch proposes, so this is not applied yet. Moving to the Drupal queue for api docs though.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

My feeling is that using the word "prefix" doesn't really clarify it much beyond what "substring" says, and when it says "the match is a right-hand match" just after that, I get confused.

So maybe these two sentences could be rewritten to explain what is actually happening in a clear manner?

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
Status: Needs work » Needs review
FileSize
409994-D6.patch747 bytes

You're correct that the combination of those two sentences could use a rewrite.

substring is definitely incorrect.

Perhaps you would prefer "starts with" to "prefix"? Can you suggest an alternate phrasing that makes more sense to you? I tried using "starts with" but all my attempts were either too verbose or grammatically awkward.

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
FileSize
409994-D6.patch797 bytes

An attempt at phrasing without using the word "prefix"

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work
FileSize
409994-D6_0.patch789 bytes

I prefer the second wording, but either #5 or #6 is fine with me.

The patch does not apply for me without some editing, though. The problem is the headers. It's best to create the patch with the CVS diff command. Barring that, remove the a/ and b/ prefixes on the file paths, and the patch will apply.

I've attached a new version of my preferred patch. Thanks for your hard work!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs work » Reviewed & tested by the community
Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented

Sorry about them git prefixes on the patch! By the way for what it's worth, you can strip off excess path parts in a patch like that by using:

patch -p1

instead of

patch -p0

Thanks for fixing it though!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Version: 6.x-dev » 7.x-dev

Let's get this to Drupal 7 first, so we are not going to introduce a regression.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
Status: Needs work » Reviewed & tested by the community

Presumably if it's RTBC in Drupal 6, then it's also RTBC in Drupal 7?

Dries’s picture

Dries CreditAttribution: Dries commented
Version: 7.x-dev » 6.x-dev

Committed to CVS HEAD.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

The patch above in #7 still applies in Drupal 6, so please commit. Thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed to Drupal 6 too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gpk’s picture

gpk CreditAttribution: gpk commented
Version: 6.x-dev » 5.x-dev
Status: Closed (fixed) » Patch (to be ported)

Same clarification would be helpful in 5.x.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Patch (to be ported) » Closed (won't fix)

7.0 is out tomorrow, 5.x is obsolete, won't fix, sorry.