We use double quotes in book_node_view_link() on lines 75-76 where single quotes will work perfectly fine, and it's probably better style to use single quotes here. The lines currently read:

          'href' => "node/add/" . str_replace('_', '-', $child_type),
          'query' => "parent=" . $node->book['mlid'],

They probably should read something more like:

          'href' => 'node/add/' . str_replace('_', '-', $child_type),
          'query' => 'parent=' . $node->book['mlid'],

I'm tagging this "novice" because it should be a very good patch for someone just beginning to get acquainted with the drupal.org patch process to attempt, but I'm also happy to do this if no one else does.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

BruceBGordon’s picture

Assigned: Unassigned » BruceBGordon

Taking this exciting task!

BruceBGordon’s picture

Status: Active » Needs review
FileSize
1.12 KB

Created a patch.

DamienMcKenna’s picture

Looks good.

Damien Tournoud’s picture

Status: Needs review » Reviewed & tested by the community

Great patch, Bruce. Thanks!

webchick’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: +Quick fix

Great job, Bruce! Always nice to get these things cleaned up. :)

Committed to HEAD!

Status: Fixed » Closed (fixed)
Issue tags: -Quick fix, -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.