We use double quotes in book_node_view_link() on lines 75-76 where single quotes will work perfectly fine, and it's probably better style to use single quotes here. The lines currently read:
'href' => "node/add/" . str_replace('_', '-', $child_type),
'query' => "parent=" . $node->book['mlid'],
They probably should read something more like:
'href' => 'node/add/' . str_replace('_', '-', $child_type),
'query' => 'parent=' . $node->book['mlid'],
I'm tagging this "novice" because it should be a very good patch for someone just beginning to get acquainted with the drupal.org patch process to attempt, but I'm also happy to do this if no one else does.
Comment | File | Size | Author |
---|---|---|---|
#2 | issue_408562_book_module_double_quotes.patch | 1.12 KB | BruceBGordon |
Comments
Comment #1
BruceBGordon CreditAttribution: BruceBGordon commentedTaking this exciting task!
Comment #2
BruceBGordon CreditAttribution: BruceBGordon commentedCreated a patch.
Comment #3
DamienMcKennaLooks good.
Comment #4
Damien Tournoud CreditAttribution: Damien Tournoud commentedGreat patch, Bruce. Thanks!
Comment #5
webchickGreat job, Bruce! Always nice to get these things cleaned up. :)
Committed to HEAD!