When creating a node, the taxonomy terms are *not* in their own fieldset like they should be. The rest of form_alter() hooks in core that append form elements to the node edit form through their inputs into their own respective fieldset. This patch fixes the taxonomy module which is the only in core that doesn't do this.

CommentFileSizeAuthor
#11 _40813_weightsagain_1.patch3.25 KBMorbus Iff
#7 _40813_weightsagain_0.patch3.26 KBMorbus Iff
#4 _40813_weightsagain.patch1.01 KBMorbus Iff
taxonomy.module_12.patch709 bytesm3avrck
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented

Just to clarify, this is the problematic screen shot:

http://www.washsq.com/tmp/t5.gif

Notice how that category is out of flow with the rest of the options for the create story. Everything else is in a fieldset.

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Status: Reviewed & tested by the community » Needs work

Let's hold this back for a sec might not be the best solution.

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Status: Needs work » Closed (fixed)

No longer needed.

Morbus Iff’s picture

Morbus Iff
they/them
CreditAttribution: Morbus Iff commented
Version: x.y.z » 4.7.0-beta1
Assigned: Unassigned » Morbus Iff
Status: Closed (fixed) » Reviewed & tested by the community
FileSize
_40813_weightsagain.patch1.01 KB

m3avrck: I'm reopening this, and setting it to be RTBC - we agree in regards to *what is in core right now*:

  1. To do what I originally wanted is a lot of work, and a new feature.
  2. Your patch is valid, in the sense that multiple categories are possible and should be grouped together.
  3. It should default, however, to non-collapsed (consider add/forum, where cat is a requirement).
  4. Dries: this also fixes a related bug I made in that weight patch, in an attempt at my desire of #1.
m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented

Ok this new patch definetly works a lot better and works as expected. Code is clean and ready to go!

chx’s picture

chx CreditAttribution: chx commented
Status: Reviewed & tested by the community » Needs work

use array_merge please. what was OK for a few attributes is a nuisance for so many.

Morbus Iff’s picture

Morbus Iff
they/them
CreditAttribution: Morbus Iff commented
Status: Needs work » Needs review
FileSize
_40813_weightsagain_0.patch3.26 KB

Attached revised patch. Uses array_merge as per chx, and fixes a missing/broken #size in "multiple" selects.

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Status: Needs review » Reviewed & tested by the community

Patch looks good and works!

chx’s picture

chx CreditAttribution: chx commented
Status: Reviewed & tested by the community » Needs work

either cast that size to integer or check_plain it but this is insecure.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs work » Reviewed & tested by the community

On second thought, it's not. No other place has #size check_plained -- who is such an idiot to put a user input data into size??

Morbus Iff’s picture

Morbus Iff
they/them
CreditAttribution: Morbus Iff commented
FileSize
_40813_weightsagain_1.patch3.25 KB

Updated patch. Fixes bad HTML for the size attribute.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)