regression from 4.6

CommentFileSizeAuthor
#6 40753_0.patch591 byteskilles@www.drop.org
#3 40753.patch401 bytesWesley Tanaka
commentformanchor.patch459 bytesWesley Tanaka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
Status: Active » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented

I think theme_comment_form() can be removed. You might be able to use #prefix instead. Please investigate. Thanks.

Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented
FileSize
40753.patch401 bytes

theme_comment_form() can't be removed if this idea:

http://www.drupalart.org/phpbb

is going to continue to hope to work with the comment form inline.

attaching equivalent patch which uses #prefix

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs review
Wesley Tanaka’s picture

Wesley Tanaka CreditAttribution: Wesley Tanaka commented

patch still applies against 4.7.0-test2

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Priority: Critical » Normal
FileSize
40753_0.patch591 bytes

I've re-rolled the patch to comply with our coding standards.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman commented
Status: Needs review » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks folks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)