Allow admin to set the node notify default

This is not possible now, so I'm marking it a feature request.

I'm not sure we should provide this because it further complicates the user interface.

I agree on the feature request. Or at least, enable the "main switch" in the profile view when a user enables notification on a comment. Apparently, today its possible to select notification when posting a comment, without getting any - until you enable comment notification in the user profile. At minimum this is a usability issue.

Oh - thanks for the comment notify module by the way :)

Bjarne

Apparently, today its possible to select notification when posting a comment, without getting any - until you enable comment notification in the user profile. At minimum this is a usability issue.

If that is the case it's a bug. I will try to test that specifically, but if you could post a "simplified, repeatable test case" it would be very helpful.

I too am very interested in this feature.

I need it on a site right now so I've done:

Changed comment_notify.module line 291 to:

  '#default_value' => isset($edit['node_notify_mailalert']) ? $edit['node_notify_mailalert'] : 1,

Changed comment_notify.module line 375 to:

  if (((!empty($author->node_notify_mailalert) && $author->node_notify_mailalert == 1) ||  empty($author->node_notify_mailalert)) && $user->mail != $author->mail) {

But there definitely needs to be an admin option to set this as default on or off that would control these lines. A little busy right now but I will work up a proper patch for review when I get a chance.

Hi,

+1

I agree that this option would be great.

Thanks.

+100

This is definitely needed. It doesn't make sense for a admin to be able to set a "Default state for the notification selection box for registered users." if it doesn't send them by default.

subscribing

Here the patch I've made for this problem. It's so simple, I don't understand why somebody else didn't already make it by now.

It seems that is now time to learn how to apply a patch ! Thank you so much !

Just two questions, does your patch also enables comment notification of comments made by the user ?

And do you know a way to enable comment notification (for posts) of all previous posts made by users before I use this patch ?

Thanks again.

It seems that is now time to learn how to apply a patch ! Thank you so much !

Just two questions, does your patch also enables comment notification of comments made by the user ?

And do you know a way to enable comment notification (for posts) of all previous posts made by users before I use this patch ?

Thanks again.

This patch adds a checkbox to the Comment Notify admin settings page that lets you specify the default for new users. See screenshot attached.

darktygur - July 31, 2009 - 13:26
Status: active » needs review

Here the patch I've made for this problem. It's so simple, I don't understand why somebody else didn't already make it by now.

Thanks so much buddy! This works great!

Any idea to enable comment notify for all previously created users ?

Thanks.

@wwwoliondorcom - http://drupal.org/node/252697

@darktygur - thanks, I'll try to review this and commit it soon.

Thank you, but I was speaking about comment notification for node creation.

I mean, all the people who previously posted a node on the website, i would like that they get notification of new messages on their node.

Possible ?

@Greggles - Any chance you will have time to review this soon?

Thanks @darkTyger - now fixed http://drupal.org/cvs?commit=277488

@Elijah Lynn - asking me to review something usually makes me less likely to review. Providing your own review (which you did, but not in a detailed way) or providing simpletests for the code is likely to make me commit it.

@Greggles - Thanks for explaining that. I need to learn how to do SimpleTests and review stuff more so than just saying "it works", maybe at DIWD or one of the Meetups I will learn that. It is a bit over my head atm.

Anyways, thanks a bunch for committing this!

Sure thing - I'll be at DIWD as well so we can chat about it more there. There is a great resource at http://drupal.org/patch/review which might be helpful.

@Greggles - Whoops, looks like I missed this comment in time for DIWD! I would have loved to take you up on your offer to talk about the patch review process. That link was very helpful though, good stuff and I will be reviewing more patches soon!

Cheers,

Elijah

This module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.