user_view() isn't merging view items correctly

array_merge() won't work because the first time you encounter $category, $fields[$category] isn't an array.

I think you'll have to do something like:

foreach ($data as $category => $content) {
  foreach ($content as $heading => $item) {
    $fields[$category][$heading] = $item;
  }
}

Please see the attached patch.

Well, I think that there are actually two different bugs. My patch addresses the one in the user module. You might want to take a swing at the one for the blog module. Compare its output to that returned by other modules, it's returning form elements not html.

the problem is that both blog and user module's _user('view') hooks return wrong structures. former an array(t('History') => $form) with $form being a form array, not a string, latter array(t('History') => array('history'=> drupal_get_form('member', $form))), with the value incorrectly being an array as well.

fix attached. please review, test, apply. this "History: Array" at user/1 looks quite unprofessional :)

oops - forgot the merging part

ax, I don't think it makes sense to remove that array.

Here's an update to my last patch that uses ax's fix for the blog module.

drewish, you are right. i was confused by the drupaldocs description of hook_user which says

"view": An associative array of *strings* to display, keyed by category name

apparently, this hasn't be updated after the relevant patch. so well - lets go on with your patch.

(note: using

+ $fields[$category][$heading] = $item;

instead of

+ $fields[$category][] = $content;

is still prone to overwriting: who tells me that i cannot use the 'blog' heading in the t('History') category for my custom module?)

humm. i think your right about the overwritting... any ideas on what the correct way to do the merge would be?

don't use user defined, but automatically generated $heading keys a la <module>-<number_of_heading_per_module>, eg. 'user-0', 'user-1', etc. in the end, the "relevant patch" (see last comment) was done to improve theming, ie. making the fields distinguishable - not to provide titles (this can be done when generating the string with the appropiate form functions).

the patch also addresses all of moshes suggestions from the "relevant patch".

TODO: update drupaldocs hook_user("view")

does anyone care to test and review this? the symptom was "History: Array" instead of "History: member for xxx days; Blog: view recent blog posts" at user/1.

thanks!

+1, the patch worked and fixed the problem with blog.module. I also tested it with a contributed module that was causing the same problem and it works there too.

This is being continued from http://drupal.org/node/45444 . Apologies for the hijack of a RTC thread.

The attached patch is similar to the above patch by Ax, Drewish et al., and my own from the other thread, except:

-The ugly forms are gone. Less processing, cleaner mark-up, and greater styling control.
-The arrays are simpler and more efficient [less nesting].
-Rather than use an auto-numbering for the classes, the patch uses a class key to specify the class. IMO this offers a lot more flexibility [+ reuse] and keeps things tidy. The actual values for the class key are the same as before. This also saves one level of nesting. The $module prefix is still present
-The form mark-up is gone replaced with definition lists. The page looks and behaves the same as before.

AFAIK the only 3 instances in core where hook_user + 'view' are called have been taken care of with this patch.

Please review and update accordingly.
Thanks :)
-K

Tested and it looks good. +1

+1

Tested the patch.

+1, zen's patch looks good.

Committed to HEAD. Thanks.

This should be documented at http://drupal.org/node/22218

I was having the problem detailed here: http://drupal.org/node/46759 ever since upgrading to beta 4.

No errors on upgrade. I would get "changes saved" after changing my password, but login results in "Sorry. Unrecognized username or password"

user history for me reads as "array"

The patch at the above node did nothing for me, but another user suggested I go here: http://drupal.org/node/46759

So I upgraded to CVS.

Now the password change still fails, however, I get.

user warning: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'user,2,3)' at line 1 query: SELECT 
DISTINCT(p.perm) FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN (authenticated user,2,3) in /home/kazys/public_html/varnelis/includes/database.mysql.inc on line 124.

Oh crap, sorry. i wish there was an edit button. i thought I was creating a new bug report, i guess not.

yet again wishing for the edit button. i meant to say i went to the node drewish suggested: http://drupal.org/node/40200

@kvarnelis: Your password issue is not related to this. Drewish meant that the "User history just displays Array" bit might be related to this. If that is the case, please disable any contrib modules and test again. Reopen this issue if need be.

Thanks
-K

thanks for pointing that out. should have done that in the first place. rusty debugging skills, but drupal 4.7 is making sure I re-learn them!

error happens when blog module (from CVS) is enabled and *all* other modules off.

error does not happen when blog module off and a whole host of other modules, including contrib modules on.

This seems to be against 4.7
Should be verified.

Wrongly reopened.