The attached patch cleans up the logging and alerts page. It simplifies the page title and the radio buttons for selecting the level of error reporting. Before and after screen shots:

CommentFileSizeAuthor
#10 logging_errors_cleanup_02.patch1.94 KBXano
#5 Screenshot.png15.34 KBcatch
#5 Screenshot.png15.34 KBcatch
#5 logging_errors_cleanup_01.patch1.95 KBcatch
logging_errors_cleanup_00.patch1.94 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented


/me blames teh input text formats.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

I'm not sure this will be an improvement. Non-techie people will have no idea which setting they 'should' be in. -1

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Assigned: Unassigned » Xano
Status: Active » Needs review
Issue tags: +Usability

What about this:

  1. None (production sites)
  2. Functional errors only (development sites)
  3. All errors (for developers)

Personally, I hate telling people how to set up their sites, since it's none of my business.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

Bojhan and I agree on the initial patch, although we need to think of a better description than "Functional errors only".

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
FileSize
logging_errors_cleanup_01.patch1.95 KB
Screenshot.png15.34 KB
Screenshot.png15.34 KB

I'm fine with this if we have some kind of indication that the radio only affects what's displayed on the screen. How about this?

screenshot

However, this could be in the title rather than the description.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

Is this really only about PHP errors?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Yes.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs review » Reviewed & tested by the community

Everything passes and we agree on the patch, so this seems like an RTBC to me :)

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs work

I disagree with this patch. "Site in development" is much more useful than "Functional errors only". Who is going to explain my mother what "functional errors" are?

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
FileSize
logging_errors_cleanup_02.patch1.94 KB

I checked common.inc and option 2 displays all messages except notices. Suggestion:

Display PHP messages:
1) None
2) Errors and warnings
3) All messages

Since this is a developer's feature, I believe it's safe to assume that Dries' mother won't touch it if she doesn't understand the label and if she does, the options are pretty self-explanatory. Everybody who actually needs this setting will know what each option means. The only drawback is that E_USER_NOTICE will also be displayed, despite it's not an error or a warning, but we could fix this in another issue, since it seems like a bug to me.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

Kick.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

I like #10.

Most of our mothers are either going to have sites set up for them, or be dealing only with a 'live' site on shared hosting - they're not going to be dealing with development / staging / live workflows at all, unless they happen to be web developers - so I don't think the extra text is helpful there.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks!

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

I'm not sure I like the changed page title to 'Display PHP messages'. These messages could be database messages, not necessarily PHP. :/

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

@Dries: Yay!

The page is about everything related to logging and alerts in Drupal. The setting about PHP messages is just about whether PHP messages and/or errors are displayed on the screen.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Got it. Could have just been "Display error messages", but overall a good change and glad it's been committed to core.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

"Display error messages" would have been a too general label, since this is stricly about PHP messages. There are other kinds of errors in Drupal as well.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Assigned: Xano » Unassigned