When I was doc'ing the #tree calculations with webchick I have discovered that the current code can be squashed quite nicely. It's not like those $foo = $foo ? $foo : $bar terniary operators, this one makes sense. I even commented it.

CommentFileSizeAuthor
#5 form_tree_simplify_1.patch1.45 KBchx
#1 form_tree_simplify_0.patch1.61 KBchx
form_tree_simplify.patch1.03 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
FileSize
form_tree_simplify_0.patch1.61 KB

I said "I commented it" -- just uploaded the wrong patch. And a minor format change in form.inc (hail feature creep :) )

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

applies (with some offset but still), works. no functionality change just code cleanup.

Dries’s picture

Dries CreditAttribution: Dries commented

Even with a comment, it's pretty hard to grasp what is going on ...

chx’s picture

chx CreditAttribution: chx commented

What about comitting it and I will --I promise-- get hold of Angie later and work a nicer code comment? :)

chx’s picture

chx CreditAttribution: chx commented
FileSize
form_tree_simplify_1.patch1.45 KB

I got hold of her :)

chx’s picture

chx CreditAttribution: chx commented
Status: Reviewed & tested by the community » Fixed

And it's in.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)