I did a search of every file in HEAD, and the taxonomy_form_all() function is not called once, anywhere. This is a redundant function, and should be removed. I believe that the patch submitted in http://drupal.org/node/19089 removed the only call to this function anywhere in the core code base.

CommentFileSizeAuthor
remove_taxonomy_form_all.patch1.07 KBJaza
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Jaza’s picture

Jaza CreditAttribution: Jaza commented
Title: taxonomy_form_all function no longer needed » taxonomy_form_all function needs to be brought back
Status: Fixed » Reviewed & tested by the community

Sorry...

It appears that taxonomy_form_all() is called by search.module. This didn't come up when I looked for instances of the function being called, as it is called through module_invoke().

Can this patch be rolled back, please? The taxonomy search box does not display in search/node without this function.

Jaza’s picture

Jaza CreditAttribution: Jaza commented

Just to clarify: this function is not called in search.module, it is called in node.module through hook_search().

And once again, sorry about the bad patch: I'll remember for next time to search for part of a function's name, rather than just the whole name.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)