isset - determines whether a variable is set

empty - determines whether a variable is empty

empty also works on array()

An empty $items passed to theme_item_list produces the following string '

    '. HTML validators choke on such empty lists.

    Replacing isset with !empty solves this problem.

    Paddy.

    CommentFileSizeAuthor
    #4 theme_item_list_1.patch987 byteschx
    #2 theme_item_list_0.patch566 byteschx
    theme-item-list.patch324 bytespaddy_deburca
    Support from Acquia helps fund testing for Drupal Acquia logo

    Comments

    paddy_deburca’s picture

    paddy_deburca CreditAttribution: paddy_deburca commented

    The following string should read as <ul></ul>

    chx’s picture

    chx CreditAttribution: chx commented
    Status: Active » Needs review
    FileSize
    theme_item_list_0.patch566 bytes

    While we are here, what about moving the whole thing into !empty($items). Do we want a div and a title when there is no list?

    killes@www.drop.org’s picture

    killes@www.drop.org CreditAttribution: killes@www.drop.org commented

    chx: I'd appreciate this, it has annoyed me for a long time.

    chx’s picture

    chx CreditAttribution: chx commented
    FileSize
    theme_item_list_1.patch987 bytes
    drumm’s picture

    drumm
    he/him
    Location NY, US
    CreditAttribution: drumm commented

    Looks good. +1

    chx’s picture

    chx CreditAttribution: chx commented
    Status: Needs review » Reviewed & tested by the community

    get this puppy in

    Dries’s picture

    Dries CreditAttribution: Dries commented
    Status: Reviewed & tested by the community » Fixed

    Committed to HEAD. Thanks.

    Anonymous’s picture

    (not verified) CreditAttribution: commented
    Status: Fixed » Closed (fixed)