See the screenshot for what I mean.

If I choose "only nodes of type blog" I should not be allowed to select "And of type book". No node is an image AND a book page.

CommentFileSizeAuthor
#2 node_filter_by_type_once_0.patch653 bytesKjartan
#1 node_filter_by_type_once.patch587 bytesedmund.kwok
node_filter_oddity.png31.95 KBBèr Kessels
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edmund.kwok’s picture

edmund.kwok CreditAttribution: edmund.kwok commented
Status: Active » Needs review
FileSize
node_filter_by_type_once.patch587 bytes

In that sense, any node can't be any two types at the same time yeah? This patch checks to see if nodes are already filtered by type, if so, the type filter is unset.

Kjartan’s picture

Kjartan CreditAttribution: Kjartan commented
Version: x.y.z » 5.0-beta1
Status: Needs review » Reviewed & tested by the community
FileSize
node_filter_by_type_once_0.patch653 bytes

Tested the patch and confirmed that it doesn't let you select multiple node types for filtering.

Attached is a clean diff against current HEAD.

Dries’s picture

Dries CreditAttribution: Dries commented

Looks good. I'd add a code comment though. Not necessary but recommended.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD with a comment.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)