Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is a blocker for PIFT 2.x.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | run_tests_remove.patch | 2.97 KB | boombatower |
| #1 | run_tests_remove.patch | 2.97 KB | boombatower |
| run_tests_remove.patch | 2.12 KB | boombatower | |
Comments
Comment #1
boombatower CreditAttribution: boombatower commentedUpdated to make it re-usable. (simpletest.module/run-tests.sh patch to follow).
Comment #2
boombatower CreditAttribution: boombatower commentedCondition was backwards. (won't show up in tests...since minor user message meant for dev.)
Comment #3
boombatower CreditAttribution: boombatower commentedPer chx's review.
Comment #4
chx CreditAttribution: chx commentedRight.
Comment #5
boombatower CreditAttribution: boombatower commentedDescription:
The run-tests.sh script ignores the variable
simpletest_clear_resultsand removes the SimpleTest test results regardless of its value, where as SimpleTest.module follows the condition.This patch creates a common function that both places call which follows the condition.
This is necessary for PIFR 2.x because it will read results directly out of database.
Comment #6
webchickDiscussed with chx and boombatower in #drupal. We have a variable called 'simpletest_clear_results' which will leave the old testing results in the database (by design) if set to false. This data can be used by the testing bot to retrieve a list of the specific tests that failed. However, since the testing bot runs run-tests.sh and not the browser-based SimpleTest, it failed to respect this setting and cleared the tables regardless.
Straight-forward patch, has approval from both testing system maintainers. Committed to HEAD. Thanks!