Bug in forms.inc expand_date function (affects all '#type' => 'date' forms) [#37494]

There is a bug either in profile.module (where it's called from) or form.inc with the "date" type form field. The date entered does not get saved.

To reproduce,

1. create a "date" field in user profile
2. set the date
3. save or just preview.

The date is going to be wrong. The reason is that all form field names for year, month, and day are the same:

<select name="edit[profile_bday]"  id="edit-profile_bday"><option ...  (for year)
...
<select name="edit[profile_bday]"  id="edit-profile_bday"><option ... (for month)
...
<select name="edit[profile_bday]"  id="edit-profile_bday"><option ... (for day)

Before the new Forms API they were:

<select name="edit[profile_date][year]" id="edit-profile_date-year"><option ...
...
<select name="edit[profile_date][month]" id="edit-profile_date-month"><option ...
...
 <select name="edit[profile_date][day]" id="edit-profile_date-day"><option ...

I couldn't figure this one out and write a patch...
Darius

Comment	File	Size	Author
#5	expand_date.patch	659 bytes	chx
#5
#3	patch_19	1.14 KB	darius
#1	patch_18	994 bytes	darius

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

darius CreditAttribution: darius commented 7 December 2005 at 23:43

Title:	New Forms API bug with "date" type form field (in profile.module)	» Bug in forms.inc expand_date function (affects all '#type' => 'date' forms)
Component:	profile.module	» base system
Priority:	Critical	» Normal
Status:	Active	» Needs review

File	Size
patch_18	994 bytes

OK, I figured this out myself, patch attached. The bug was in expand_date function in forms.inc.

Darius

Comment #2

chx CreditAttribution: chx commented 8 December 2005 at 00:39

Status:

Needs review

» Needs work

'#name' => $element['#name']."[$type]" this makes no sense. Maybe you want $element['#tree'] TRUE? just a guess from the patch. If that works, then you can delete #parents and #tree from the [$type] array.