Like #368502: File naming test sometimes fails, seemingly randomly the testing bot reports an exception in the "Field form tests" in field.test. See for example http://testing.drupal.org/pifr/file/1/3831 which is entirely unrelated.

I thought it was down to one slave, but it spans several.

In the file.test problem, it seems that was related to using randomName(). Not sure if the same thing is happening here though.

Anyway, this is sapping away developer confidence in the bot so it should be fixed ASAP.

CommentFileSizeAuthor
#7 field_fix_tests-371363-6.patch4.93 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented

I there a way to know which exact test failed in the example you provide ?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

It might be possible for someone with access to the testing slaves, but it's not via the existing test bot UI. (subscribing).

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

I've switched the test bot off.

Had a quick look through the test - should use drupal_strotolower() instead of strtolower() didn't spot anywhere else obvious.
#371422: field form test should use drupal_strtolower()

bjaspan’s picture

bjaspan CreditAttribution: bjaspan commented

Probably unrelated, but I've noticed that the field form tests always fail for me when run from the command line, but not from the UI. I suspect the cause is that my base URL has a port number, e.g. http://head.local:8888. Somehow, the command line is not using the port number.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented

Well the test bot does run all tests from the command line, so that's possibly related. It's not doing so on an alternate port, however.

yched’s picture

yched CreditAttribution: yched commented

re #1 - Berdir posted this on IRC : http://dev.worldempire.ch/fieldformtestfail.png

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
FileSize
field_fix_tests-371363-6.patch4.93 KB

Doh. Field_test fields are considered empty if empty($value), so the tests break when the random assigned value is 0...
Attached patch uses rand(1, 127) instead of rand(0, 127).

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Congrats!

alexanderpas’s picture

alexanderpas CreditAttribution: alexanderpas commented

nice work!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

YES!!

Thanks SO much, yched!! :D

Committed to HEAD! Switching testing bot back on momentarily.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.